From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LQK3L-0007uu-Iq
	for qemu-devel@nongnu.org; Fri, 23 Jan 2009 06:18:23 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LQK3K-0007rc-9N
	for qemu-devel@nongnu.org; Fri, 23 Jan 2009 06:18:22 -0500
Received: from [199.232.76.173] (port=46134 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LQK3J-0007r0-SI
	for qemu-devel@nongnu.org; Fri, 23 Jan 2009 06:18:21 -0500
Received: from mx2.redhat.com ([66.187.237.31]:35885)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1LQK3J-0008Bp-En
	for qemu-devel@nongnu.org; Fri, 23 Jan 2009 06:18:21 -0500
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26])
	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n0NBIIWj000478
	for <qemu-devel@nongnu.org>; Fri, 23 Jan 2009 06:18:18 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])
	by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n0NBIIXm010137
	for <qemu-devel@nongnu.org>; Fri, 23 Jan 2009 06:18:18 -0500
Received: from zweiblum.travel.kraxel.org (vpn-10-167.str.redhat.com
	[10.32.10.167])
	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n0NBIHTZ028901
	for <qemu-devel@nongnu.org>; Fri, 23 Jan 2009 06:18:18 -0500
Message-ID: <4979A777.1060909@redhat.com>
Date: Fri, 23 Jan 2009 12:18:15 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [6396] I/O vector helpers (Avi Kivity)
References: <E1LQ2tl-0003Ks-0e@cvs.savannah.gnu.org>
In-Reply-To: <E1LQ2tl-0003Ks-0e@cvs.savannah.gnu.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Anthony Liguori wrote:
> +void qemu_iovec_add(QEMUIOVector *qiov, void *base, size_t len)
> +{
> +    if (qiov->niov == qiov->nalloc) {
> +        qiov->nalloc = 2 * qiov->nalloc + 1;
> +        qiov->iov = qemu_realloc(qiov->iov, qiov->nalloc * sizeof(struct iovec));
> +    }
> +    qiov->iov[qiov->niov].iov_base = base;
> +    qiov->iov[qiov->niov].iov_len = len;
> +    ++qiov->niov;
> +}

Breaks the build:

AR libqemu.a
LINK qemu-x86_64
../libqemu_user.a(cutils.o): In function `qemu_iovec_add':
/home/kraxel/projects/qemu/cutils.c:118: undefined reference to
`qemu_realloc'
collect2: ld returned 1 exit status
make[1]: *** [qemu-x86_64] Error 1
make[1]: Leaving directory `/home/kraxel/projects/qemu/x86_64-linux-user'
make: *** [subdir-x86_64-linux-user] Error 2

cheers,
  Gerd