From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LQpVG-0003SH-3S
	for qemu-devel@nongnu.org; Sat, 24 Jan 2009 15:53:18 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LQpVE-0003S5-JF
	for qemu-devel@nongnu.org; Sat, 24 Jan 2009 15:53:17 -0500
Received: from [199.232.76.173] (port=54345 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LQpVE-0003S2-GB
	for qemu-devel@nongnu.org; Sat, 24 Jan 2009 15:53:16 -0500
Received: from an-out-0708.google.com ([209.85.132.250]:4217)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1LQpVE-00011k-5g
	for qemu-devel@nongnu.org; Sat, 24 Jan 2009 15:53:16 -0500
Received: by an-out-0708.google.com with SMTP id b6so937074ana.37
	for <qemu-devel@nongnu.org>; Sat, 24 Jan 2009 12:53:15 -0800 (PST)
Message-ID: <497B7FAD.30005@codemonkey.ws>
Date: Sat, 24 Jan 2009 14:53:01 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Disable AIO for Mac OS X
References: <1232827167-19058-1-git-send-email-agraf@suse.de>	<497B7A03.6040905@codemonkey.ws>
	<BDA515CE-2404-4980-A190-A5746A1B7F03@suse.de>
In-Reply-To: <BDA515CE-2404-4980-A190-A5746A1B7F03@suse.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Alexander Graf wrote:
>
> On 24.01.2009, at 21:28, Anthony Liguori wrote:
>
>> Alexander Graf wrote:
>>> While trying current svn, it looks like AIO support compiles on
>>> Mac OS X finally. Unfortunately it is broken and as soon as I want
>>> to run any image, it endless loops in block.c:1446 which is:
>>>
>>>    while (async_ret == NOT_DONE) {
>>>        qemu_aio_wait();
>>>    }
>>>
>>
>> Are you using cocoa?
>
> Yep. Nothing else works for x86_64 on Mac OS X ;-). Well - except for 
> vnc.
>
>> I don't think the AIO code is broken here.  I think something else is 
>> broken and disabling AIO hides the symptom.  Can you dig more into this?
>
> Hum - sounds like an idea. I'm open for hints on how to dig in here. I 
> can disable cocoa for starters of course.

My guess would be that the completion signal isn't being delivered.  I'd 
start by disabling cocoa and then annotate things to see if the 
completion signal every makes it to the aio system.

Regards,

Anthony Liguori

>
> Alex
>
>>
>>
>> Regards,
>>
>> Anthony Liguori
>>
>>> So for the time being, let's simply disable aio for Mac OS X.
>>>
>>> Signed-off-by: Alexander Graf <agraf@suse.de>
>>> ---
>>> configure |    1 +
>>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/configure b/configure
>>> index c3fbbbe..3e701b9 100755
>>> --- a/configure
>>> +++ b/configure
>>> @@ -259,6 +259,7 @@ cocoa="yes"
>>> audio_drv_list="coreaudio"
>>> audio_possible_drivers="coreaudio sdl fmod"
>>> OS_LDFLAGS="-framework CoreFoundation -framework IOKit"
>>> +aio="no"
>>> ;;
>>> SunOS)
>>>     solaris="yes"
>>>
>>
>>
>>
>
>
>