From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LRWom-0001Fl-0b
	for qemu-devel@nongnu.org; Mon, 26 Jan 2009 14:08:20 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LRWok-0001DM-Rl
	for qemu-devel@nongnu.org; Mon, 26 Jan 2009 14:08:19 -0500
Received: from [199.232.76.173] (port=52287 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LRWok-0001Cl-AD
	for qemu-devel@nongnu.org; Mon, 26 Jan 2009 14:08:18 -0500
Received: from mx20.gnu.org ([199.232.41.8]:51900)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <aliguori@us.ibm.com>) id 1LRV2b-0004VU-ES
	for qemu-devel@nongnu.org; Mon, 26 Jan 2009 12:14:29 -0500
Received: from e2.ny.us.ibm.com ([32.97.182.142])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <aliguori@us.ibm.com>) id 1LRTeh-0007he-L4
	for qemu-devel@nongnu.org; Mon, 26 Jan 2009 10:45:43 -0500
Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234])
	by e2.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n0QFbVCH030288
	for <qemu-devel@nongnu.org>; Mon, 26 Jan 2009 10:37:31 -0500
Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215])
	by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id
	n0QFd9KZ195054
	for <qemu-devel@nongnu.org>; Mon, 26 Jan 2009 10:39:09 -0500
Received: from d01av01.pok.ibm.com (loopback [127.0.0.1])
	by d01av01.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
	n0QFd9mj007268
	for <qemu-devel@nongnu.org>; Mon, 26 Jan 2009 10:39:09 -0500
Received: from squirrel.codemonkey.ws (sig-9-65-32-74.mts.ibm.com [9.65.32.74])
	by d01av01.pok.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id
	n0QFd9AU007239
	for <qemu-devel@nongnu.org>; Mon, 26 Jan 2009 10:39:09 -0500
Message-ID: <497DD911.9050009@us.ibm.com>
Date: Mon, 26 Jan 2009 09:38:57 -0600
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] [v2] Define PCI vendor and device IDs in
	pci.h
References: <20090124165342.GA29800@miranda.arrow>
In-Reply-To: <20090124165342.GA29800@miranda.arrow>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Stuart Brady wrote:
> This patch defines PCI vendor and device IDs in pci.h (matching those
> from Linux's pci_ids.h), and uses those definitions where appropriate.
>
> Change from v1:
>   Introduces pci_config_set_vendor_id() / pci_config_set_device_id()
>   accessors as suggested by Anthony Liguori.
>
> Signed-off-by: Stuart Brady <stuart.brady@gmail.com>
>   
Applied.  Thanks.

If anyone is looking for a janitor-type job, adding more config 
accessors and adding defines for class-types, devices, etc. it would go 
a long way to making a lot of that code more readable.

Regards,

Anthony Liguori