qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] build system: Further improve quiet mode
Date: Mon, 26 Jan 2009 19:08:20 +0100	[thread overview]
Message-ID: <497DFC14.6010305@siemens.com> (raw)
In-Reply-To: <497DEE21.3070104@us.ibm.com>

Anthony Liguori wrote:
> 
>> Derived from Stuart Brady's patch: Show the target directory as prefix
>> to the current module when building in quiet mode. This helps to gain
>> overview of the current build progress, specifically when running
>> parallelized builds.
>>
>> Furthermore, suppress make command echoing when entering subdirs and
>> replace $(subst subdir-,,$@) with $* in the related rule.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> Applied.  Thanks.
> 
> The output really does look better.
> 

Accidentally missed -v2? If yes, here is the delta:

------>

Add-on to the previous patch: On request by Laurent Desnogues dump the
used CFLAGS and LDFLAGS once on startup of the quiet mode.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---

 Makefile  |    5 ++++-
 rules.mak |    2 +-
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index 4f7a55a..6a7db93 100644
--- a/Makefile
+++ b/Makefile
@@ -34,7 +34,10 @@ ifdef CONFIG_WIN32
 LIBS+=-lwinmm -lws2_32 -liphlpapi
 endif
 
-all: $(TOOLS) $(DOCS) recurse-all
+all:
+	$(call quiet-command,$(MAKE) build-all,"Building with\n  CFLAGS  = $(CFLAGS)\n  LDFLAGS = $(LDFLAGS)")
+
+build-all: $(TOOLS) $(DOCS) recurse-all
 
 SUBDIR_RULES=$(patsubst %,subdir-%, $(TARGET_DIRS))
 
diff --git a/rules.mak b/rules.mak
index a75a93b..10e21ec 100644
--- a/rules.mak
+++ b/rules.mak
@@ -16,4 +16,4 @@ LINK = $(call quiet-command,$(CC) $(LDFLAGS) -o $@ $^ $(LIBS),"  LINK  $(TARGET_
 %.a:
 	$(call quiet-command,rm -f $@ && $(AR) rcs $@ $^,"  AR    $(TARGET_DIR)$@")
 
-quiet-command = $(if $(V),$1,$(if $(2),@echo $2 && $1, @$1))
+quiet-command = $(if $(V),$1,$(if $(2),@echo -e $2 && $1, @$1))

      reply	other threads:[~2009-01-26 18:08 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-21 18:13 [Qemu-devel] [6380] Make make output quieter (Avi Kivity) Anthony Liguori
2009-01-24 15:10 ` Stuart Brady
2009-01-25 15:53   ` [Qemu-devel] [PATCH] build system: Further improve quiet mode (was: Re: [6380] Make make output quieter (Avi Kivity)) Jan Kiszka
2009-01-25 15:56     ` Laurent Desnogues
2009-01-25 16:30       ` [Qemu-devel] Re: [PATCH] build system: Further improve quiet mode Jan Kiszka
2009-01-25 16:39         ` Laurent Desnogues
2009-01-26 17:36         ` Anthony Liguori
2009-01-26 18:58           ` Lionel Landwerlin
2009-01-26 18:58           ` Paul Brook
2009-01-26 19:41             ` Anthony Liguori
2009-01-27  9:23               ` Laurent Desnogues
2009-01-27  9:47                 ` Jan Kiszka
2009-01-27  9:49                   ` Jan Kiszka
2009-01-26 19:04           ` Laurent Desnogues
2009-01-26 17:08     ` [Qemu-devel] " Anthony Liguori
2009-01-26 18:08       ` Jan Kiszka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=497DFC14.6010305@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).