From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LRVsm-0006eI-IZ for qemu-devel@nongnu.org; Mon, 26 Jan 2009 13:08:24 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LRVsl-0006dU-4T for qemu-devel@nongnu.org; Mon, 26 Jan 2009 13:08:24 -0500 Received: from [199.232.76.173] (port=51724 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LRVsk-0006dG-Kh for qemu-devel@nongnu.org; Mon, 26 Jan 2009 13:08:22 -0500 Received: from gecko.sbs.de ([194.138.37.40]:23202) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LRVsj-00075t-5h for qemu-devel@nongnu.org; Mon, 26 Jan 2009 13:08:21 -0500 Received: from mail2.sbs.de (localhost [127.0.0.1]) by gecko.sbs.de (8.12.11.20060308/8.12.11) with ESMTP id n0QI8Hbl008598 for ; Mon, 26 Jan 2009 19:08:17 +0100 Received: from [139.25.109.167] (mchn012c.mchp.siemens.de [139.25.109.167] (may be forged)) by mail2.sbs.de (8.12.11.20060308/8.12.11) with ESMTP id n0QI8GBb021316 for ; Mon, 26 Jan 2009 19:08:17 +0100 Message-ID: <497DFC14.6010305@siemens.com> Date: Mon, 26 Jan 2009 19:08:20 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <20090124151035.GA29283@miranda.arrow> <497C8AF6.8010401@web.de> <497DEE21.3070104@us.ibm.com> In-Reply-To: <497DEE21.3070104@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] build system: Further improve quiet mode Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Anthony Liguori wrote: > >> Derived from Stuart Brady's patch: Show the target directory as prefix >> to the current module when building in quiet mode. This helps to gain >> overview of the current build progress, specifically when running >> parallelized builds. >> >> Furthermore, suppress make command echoing when entering subdirs and >> replace $(subst subdir-,,$@) with $* in the related rule. >> >> Signed-off-by: Jan Kiszka > Applied. Thanks. > > The output really does look better. > Accidentally missed -v2? If yes, here is the delta: ------> Add-on to the previous patch: On request by Laurent Desnogues dump the used CFLAGS and LDFLAGS once on startup of the quiet mode. Signed-off-by: Jan Kiszka --- Makefile | 5 ++++- rules.mak | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 4f7a55a..6a7db93 100644 --- a/Makefile +++ b/Makefile @@ -34,7 +34,10 @@ ifdef CONFIG_WIN32 LIBS+=-lwinmm -lws2_32 -liphlpapi endif -all: $(TOOLS) $(DOCS) recurse-all +all: + $(call quiet-command,$(MAKE) build-all,"Building with\n CFLAGS = $(CFLAGS)\n LDFLAGS = $(LDFLAGS)") + +build-all: $(TOOLS) $(DOCS) recurse-all SUBDIR_RULES=$(patsubst %,subdir-%, $(TARGET_DIRS)) diff --git a/rules.mak b/rules.mak index a75a93b..10e21ec 100644 --- a/rules.mak +++ b/rules.mak @@ -16,4 +16,4 @@ LINK = $(call quiet-command,$(CC) $(LDFLAGS) -o $@ $^ $(LIBS)," LINK $(TARGET_ %.a: $(call quiet-command,rm -f $@ && $(AR) rcs $@ $^," AR $(TARGET_DIR)$@") -quiet-command = $(if $(V),$1,$(if $(2),@echo $2 && $1, @$1)) +quiet-command = $(if $(V),$1,$(if $(2),@echo -e $2 && $1, @$1))