From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LRVtJ-0006sa-Ql for qemu-devel@nongnu.org; Mon, 26 Jan 2009 13:08:57 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LRVtI-0006s1-R4 for qemu-devel@nongnu.org; Mon, 26 Jan 2009 13:08:57 -0500 Received: from [199.232.76.173] (port=51776 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LRVtI-0006rs-Nc for qemu-devel@nongnu.org; Mon, 26 Jan 2009 13:08:56 -0500 Received: from lizzard.sbs.de ([194.138.37.39]:23632) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LRVtH-0007Gw-NM for qemu-devel@nongnu.org; Mon, 26 Jan 2009 13:08:56 -0500 Received: from mail2.sbs.de (localhost [127.0.0.1]) by lizzard.sbs.de (8.12.11.20060308/8.12.11) with ESMTP id n0QI8ruC022311 for ; Mon, 26 Jan 2009 19:08:53 +0100 Received: from [139.25.109.167] (mchn012c.ww002.siemens.net [139.25.109.167] (may be forged)) by mail2.sbs.de (8.12.11.20060308/8.12.11) with ESMTP id n0QI8reV021458 for ; Mon, 26 Jan 2009 19:08:53 +0100 Message-ID: <497DFC38.6040402@siemens.com> Date: Mon, 26 Jan 2009 19:08:56 +0100 From: Jan Kiszka MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH] kvm-x86: Remove eflags conversion into emulator format Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel It seems that the conversion of the kernel-delivered eflags state into qemu's internal split representation was once needed in an older kvm design (register read-back may have taken place from inside cpu_exec). Today it is plain wrong and causes incorrect cpu state reporting (gdb, monitor) and should also corrupt its saving (savevm, migration). Drop the related lines. Signed-off-by: Jan Kiszka --- target-i386/kvm.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 88c3137..47723f2 100644 --- a/target-i386/kvm.c +++ b/target-i386/kvm.c @@ -446,10 +446,6 @@ static int kvm_get_sregs(CPUState *env) } } env->hflags = (env->hflags & HFLAG_COPY_MASK) | hflags; - env->cc_src = env->eflags & (CC_O | CC_S | CC_Z | CC_A | CC_P | CC_C); - env->df = 1 - (2 * ((env->eflags >> 10) & 1)); - env->cc_op = CC_OP_EFLAGS; - env->eflags &= ~(DF_MASK | CC_O | CC_S | CC_Z | CC_A | CC_P | CC_C); return 0; }