[Qemu-devel] [PATCH] kvm-x86: Remove eflags conversion into emulator format

[Qemu-devel] [PATCH] kvm-x86: Remove eflags conversion into emulator format

[Jan Kiszka]

It seems that the conversion of the kernel-delivered eflags state into
qemu's internal split representation was once needed in an older kvm
design (register read-back may have taken place from inside cpu_exec).
Today it is plain wrong and causes incorrect cpu state reporting (gdb,
monitor) and should also corrupt its saving (savevm, migration). Drop
the related lines.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---

 target-i386/kvm.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/target-i386/kvm.c b/target-i386/kvm.c
index 88c3137..47723f2 100644
--- a/target-i386/kvm.c
+++ b/target-i386/kvm.c
@@ -446,10 +446,6 @@ static int kvm_get_sregs(CPUState *env)
             }
     }
     env->hflags = (env->hflags & HFLAG_COPY_MASK) | hflags;
-    env->cc_src = env->eflags & (CC_O | CC_S | CC_Z | CC_A | CC_P | CC_C);
-    env->df = 1 - (2 * ((env->eflags >> 10) & 1));
-    env->cc_op = CC_OP_EFLAGS;
-    env->eflags &= ~(DF_MASK | CC_O | CC_S | CC_Z | CC_A | CC_P | CC_C);
 
     return 0;
 }

Re: [Qemu-devel] [PATCH] kvm-x86: Remove eflags conversion into emulator format

[Anthony Liguori]

Jan Kiszka wrote:
> It seems that the conversion of the kernel-delivered eflags state into
> qemu's internal split representation was once needed in an older kvm
> design (register read-back may have taken place from inside cpu_exec).
> Today it is plain wrong and causes incorrect cpu state reporting (gdb,
> monitor) and should also corrupt its saving (savevm, migration). Drop
> the related lines.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>   

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
>
>  target-i386/kvm.c |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
> index 88c3137..47723f2 100644
> --- a/target-i386/kvm.c
> +++ b/target-i386/kvm.c
> @@ -446,10 +446,6 @@ static int kvm_get_sregs(CPUState *env)
>              }
>      }
>      env->hflags = (env->hflags & HFLAG_COPY_MASK) | hflags;
> -    env->cc_src = env->eflags & (CC_O | CC_S | CC_Z | CC_A | CC_P | CC_C);
> -    env->df = 1 - (2 * ((env->eflags >> 10) & 1));
> -    env->cc_op = CC_OP_EFLAGS;
> -    env->eflags &= ~(DF_MASK | CC_O | CC_S | CC_Z | CC_A | CC_P | CC_C);
>  
>      return 0;
>  }
>
>
>
>