From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LRZgC-00072U-TA
	for qemu-devel@nongnu.org; Mon, 26 Jan 2009 17:11:40 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LRZgB-000726-Cv
	for qemu-devel@nongnu.org; Mon, 26 Jan 2009 17:11:40 -0500
Received: from [199.232.76.173] (port=44532 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LRZgB-00071z-7U
	for qemu-devel@nongnu.org; Mon, 26 Jan 2009 17:11:39 -0500
Received: from qw-out-1920.google.com ([74.125.92.146]:31796)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1LRZgA-00068S-VL
	for qemu-devel@nongnu.org; Mon, 26 Jan 2009 17:11:39 -0500
Received: by qw-out-1920.google.com with SMTP id 5so1196047qwc.4
	for <qemu-devel@nongnu.org>; Mon, 26 Jan 2009 14:11:37 -0800 (PST)
Message-ID: <497E350B.6080003@codemonkey.ws>
Date: Mon, 26 Jan 2009 16:11:23 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [RESEND][PATCH] gdbstub: listen on ipv4 address
References: <6DF473C7837D4A31A3A6AF10F70F0F63@FSCPC>
In-Reply-To: <6DF473C7837D4A31A3A6AF10F70F0F63@FSCPC>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Sebastian Herbszt wrote:
> Make gdbstub listen on ipv4 address like before r5697.

Any reason to make it explicit?

BTW, the patch needs a signed-off-by.

Regards,

Anthony Liguori

> - Sebastian
>
> --- qemu-r6133/gdbstub.c.orig Sat Dec 27 15:57:16 2008
> +++ qemu-r6133/gdbstub.c Sat Dec 27 15:57:29 2008
> @@ -2276,7 +2276,7 @@
>     if (*p == 0) {
>         /* A numeric value is interpreted as a port number.  */
>         snprintf(gdbstub_port_name, sizeof(gdbstub_port_name),
> -                 "tcp::%d,nowait,nodelay,server", port_num);
> +                 "tcp::%d,nowait,nodelay,server,ipv4", port_num);
>         port = gdbstub_port_name;
>     }
>
>
>
>