From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LRa3K-0005dV-H9
	for qemu-devel@nongnu.org; Mon, 26 Jan 2009 17:35:34 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LRa3I-0005az-HK
	for qemu-devel@nongnu.org; Mon, 26 Jan 2009 17:35:34 -0500
Received: from [199.232.76.173] (port=37025 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LRa3I-0005ak-Cs
	for qemu-devel@nongnu.org; Mon, 26 Jan 2009 17:35:32 -0500
Received: from e1.ny.us.ibm.com ([32.97.182.141]:57069)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <aliguori@us.ibm.com>) id 1LRa3I-0000ap-3b
	for qemu-devel@nongnu.org; Mon, 26 Jan 2009 17:35:32 -0500
Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234])
	by e1.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n0QMXsd6024563
	for <qemu-devel@nongnu.org>; Mon, 26 Jan 2009 17:33:54 -0500
Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216])
	by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id
	n0QMZT9u192752
	for <qemu-devel@nongnu.org>; Mon, 26 Jan 2009 17:35:29 -0500
Received: from d01av02.pok.ibm.com (loopback [127.0.0.1])
	by d01av02.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
	n0QMYWmV026334
	for <qemu-devel@nongnu.org>; Mon, 26 Jan 2009 17:34:33 -0500
Received: from squirrel.codemonkey.ws (sig-9-65-32-74.mts.ibm.com [9.65.32.74])
	by d01av02.pok.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id
	n0QMYWx2026327
	for <qemu-devel@nongnu.org>; Mon, 26 Jan 2009 17:34:32 -0500
Message-ID: <497E3AA4.70501@us.ibm.com>
Date: Mon, 26 Jan 2009 16:35:16 -0600
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [RESEND][PATCH] qemu_chr_open_tcp: allow ipv4 and
	ipv6	options
References: <5A5201B4FE9C4DA2863CFFF07051BFB6@FSCPC>
In-Reply-To: <5A5201B4FE9C4DA2863CFFF07051BFB6@FSCPC>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Sebastian Herbszt wrote:
> Those new options are parsed in qemu-sockets.c. Allow them instead of 
> printing "Unknown option".

Needs a Signed-off-by line.

Regards,

Anthony Liguori

> - Sebastian
>
> --- qemu-r6133/qemu-char.c.orig Sat Dec 27 15:55:48 2008
> +++ qemu-r6133/qemu-char.c Sat Dec 27 16:54:23 2008
> @@ -2035,6 +2035,10 @@
>             do_nodelay = 1;
>         } else if (!strncmp(ptr,"to=",3)) {
>             /* nothing, inet_listen() parses this one */;
> +        } else if (!strncmp(ptr,"ipv4",4)) {
> +            /* nothing, inet_connect() and inet_listen() parse this 
> one */;
> +        } else if (!strncmp(ptr,"ipv6",4)) {
> +            /* nothing, inet_connect() and inet_listen() parse this 
> one */;
>         } else {
>             printf("Unknown option: %s\n", ptr);
>             goto fail;
>
>
>
>