* [Qemu-devel] [RESEND][PATCH] qemu_chr_open_tcp: allow ipv4 and ipv6 options
@ 2009-01-26 20:21 Sebastian Herbszt
2009-01-26 22:35 ` Anthony Liguori
2009-02-09 20:09 ` [Qemu-devel] [RESEND][PATCH] qemu_chr_open_tcp: allow ipv4 and ipv6 options Aurelien Jarno
0 siblings, 2 replies; 4+ messages in thread
From: Sebastian Herbszt @ 2009-01-26 20:21 UTC (permalink / raw)
To: qemu-devel
Those new options are parsed in qemu-sockets.c. Allow them instead of printing "Unknown option".
- Sebastian
--- qemu-r6133/qemu-char.c.orig Sat Dec 27 15:55:48 2008
+++ qemu-r6133/qemu-char.c Sat Dec 27 16:54:23 2008
@@ -2035,6 +2035,10 @@
do_nodelay = 1;
} else if (!strncmp(ptr,"to=",3)) {
/* nothing, inet_listen() parses this one */;
+ } else if (!strncmp(ptr,"ipv4",4)) {
+ /* nothing, inet_connect() and inet_listen() parse this one */;
+ } else if (!strncmp(ptr,"ipv6",4)) {
+ /* nothing, inet_connect() and inet_listen() parse this one */;
} else {
printf("Unknown option: %s\n", ptr);
goto fail;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [RESEND][PATCH] qemu_chr_open_tcp: allow ipv4 and ipv6 options
2009-01-26 20:21 [Qemu-devel] [RESEND][PATCH] qemu_chr_open_tcp: allow ipv4 and ipv6 options Sebastian Herbszt
@ 2009-01-26 22:35 ` Anthony Liguori
2009-01-27 22:18 ` [Qemu-devel] Re: [RESEND][PATCH] qemu_chr_open_tcp: allow ipv4 andipv6 options Sebastian Herbszt
2009-02-09 20:09 ` [Qemu-devel] [RESEND][PATCH] qemu_chr_open_tcp: allow ipv4 and ipv6 options Aurelien Jarno
1 sibling, 1 reply; 4+ messages in thread
From: Anthony Liguori @ 2009-01-26 22:35 UTC (permalink / raw)
To: qemu-devel
Sebastian Herbszt wrote:
> Those new options are parsed in qemu-sockets.c. Allow them instead of
> printing "Unknown option".
Needs a Signed-off-by line.
Regards,
Anthony Liguori
> - Sebastian
>
> --- qemu-r6133/qemu-char.c.orig Sat Dec 27 15:55:48 2008
> +++ qemu-r6133/qemu-char.c Sat Dec 27 16:54:23 2008
> @@ -2035,6 +2035,10 @@
> do_nodelay = 1;
> } else if (!strncmp(ptr,"to=",3)) {
> /* nothing, inet_listen() parses this one */;
> + } else if (!strncmp(ptr,"ipv4",4)) {
> + /* nothing, inet_connect() and inet_listen() parse this
> one */;
> + } else if (!strncmp(ptr,"ipv6",4)) {
> + /* nothing, inet_connect() and inet_listen() parse this
> one */;
> } else {
> printf("Unknown option: %s\n", ptr);
> goto fail;
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* [Qemu-devel] Re: [RESEND][PATCH] qemu_chr_open_tcp: allow ipv4 andipv6 options
2009-01-26 22:35 ` Anthony Liguori
@ 2009-01-27 22:18 ` Sebastian Herbszt
0 siblings, 0 replies; 4+ messages in thread
From: Sebastian Herbszt @ 2009-01-27 22:18 UTC (permalink / raw)
To: qemu-devel
Anthony Liguori wrote:
> Sebastian Herbszt wrote:
>> Those new options are parsed in qemu-sockets.c. Allow them instead of
>> printing "Unknown option".
>
> Needs a Signed-off-by line.
Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
- Sebastian
> Regards,
>
> Anthony Liguori
>
>> - Sebastian
>>
>> --- qemu-r6133/qemu-char.c.orig Sat Dec 27 15:55:48 2008
>> +++ qemu-r6133/qemu-char.c Sat Dec 27 16:54:23 2008
>> @@ -2035,6 +2035,10 @@
>> do_nodelay = 1;
>> } else if (!strncmp(ptr,"to=",3)) {
>> /* nothing, inet_listen() parses this one */;
>> + } else if (!strncmp(ptr,"ipv4",4)) {
>> + /* nothing, inet_connect() and inet_listen() parse this
>> one */;
>> + } else if (!strncmp(ptr,"ipv6",4)) {
>> + /* nothing, inet_connect() and inet_listen() parse this
>> one */;
>> } else {
>> printf("Unknown option: %s\n", ptr);
>> goto fail;
>>
>>
>>
>>
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [RESEND][PATCH] qemu_chr_open_tcp: allow ipv4 and ipv6 options
2009-01-26 20:21 [Qemu-devel] [RESEND][PATCH] qemu_chr_open_tcp: allow ipv4 and ipv6 options Sebastian Herbszt
2009-01-26 22:35 ` Anthony Liguori
@ 2009-02-09 20:09 ` Aurelien Jarno
1 sibling, 0 replies; 4+ messages in thread
From: Aurelien Jarno @ 2009-02-09 20:09 UTC (permalink / raw)
To: Sebastian Herbszt; +Cc: qemu-devel
On Mon, Jan 26, 2009 at 09:21:58PM +0100, Sebastian Herbszt wrote:
> Those new options are parsed in qemu-sockets.c. Allow them instead of printing "Unknown option".
>
> - Sebastian
Thanks, applied.
> --- qemu-r6133/qemu-char.c.orig Sat Dec 27 15:55:48 2008
> +++ qemu-r6133/qemu-char.c Sat Dec 27 16:54:23 2008
> @@ -2035,6 +2035,10 @@
> do_nodelay = 1;
> } else if (!strncmp(ptr,"to=",3)) {
> /* nothing, inet_listen() parses this one */;
> + } else if (!strncmp(ptr,"ipv4",4)) {
> + /* nothing, inet_connect() and inet_listen() parse this one */;
> + } else if (!strncmp(ptr,"ipv6",4)) {
> + /* nothing, inet_connect() and inet_listen() parse this one */;
> } else {
> printf("Unknown option: %s\n", ptr);
> goto fail;
>
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-02-09 20:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-26 20:21 [Qemu-devel] [RESEND][PATCH] qemu_chr_open_tcp: allow ipv4 and ipv6 options Sebastian Herbszt
2009-01-26 22:35 ` Anthony Liguori
2009-01-27 22:18 ` [Qemu-devel] Re: [RESEND][PATCH] qemu_chr_open_tcp: allow ipv4 andipv6 options Sebastian Herbszt
2009-02-09 20:09 ` [Qemu-devel] [RESEND][PATCH] qemu_chr_open_tcp: allow ipv4 and ipv6 options Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).