[Qemu-devel] Re: [PATCH] build system: Further improve quiet mode

[Jan Kiszka <jan.kiszka@siemens.com>]

Jan Kiszka wrote:
> Laurent Desnogues wrote:
>> On Mon, Jan 26, 2009 at 8:41 PM, Anthony Liguori <anthony@codemonkey.ws> wrote:
>>> Paul Brook wrote:
>>>>> BTW, what do people think of printing CFLAGS?  I find it not all that
>>>>> exciting but if people like it, I'm happy to go with it.
>>>>>
>>>> I don't find it that interesting either. Especially given we use at least
>>>> two different sets of CFLAGS, and you really also need to know which
>>>> compiler is being invoked. You can always use V=1.
>>>>
>>> That was my thinking too.  The more noise in the build output, the less
>>> useful the quiet mode is wrt catching warnings.
>> So what about this?
>>
>>
>> Laurent
>>
>> - Make user-mode build process quieter.
>>
>> Signed-off-by: Laurent Desnogues <laurent.desnogues@gmail.com>
>>
>> Index: Makefile.target
>> ===================================================================
>> --- Makefile.target	(revision 6463)
>> +++ Makefile.target	(working copy)
>> @@ -725,9 +725,9 @@
>>  endif # !CONFIG_USER_ONLY
>>  
>>  gdbstub-xml.c: $(TARGET_XML_FILES) feature_to_c.sh
>> -	rm -f $@
>> +	$(call quiet-command,rm -f $@)
>>  ifeq ($(TARGET_XML_FILES),)
>> -	echo > $@
>> +	$(call quiet-command,echo > $@)
>>  else
>>  	$(SHELL) $(SRC_PATH)/feature_to_c.sh $@ $(TARGET_XML_FILES)
>>  endif
> 
> I was thinking in this direction already as well. But please go for a
> canonical output, something like
> 
>   GENERATE ppc-softmmu/gdbstub-xml.c
> 
> (Likely requires adjusting indention of the other rules.)

Or simply use

  GEN   ppc-softmmu/gdbstub-xml.c

which fits into the existing layout.

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux