From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LRkZI-0004nc-QJ for qemu-devel@nongnu.org; Tue, 27 Jan 2009 04:49:16 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LRkZH-0004nM-8h for qemu-devel@nongnu.org; Tue, 27 Jan 2009 04:49:16 -0500 Received: from [199.232.76.173] (port=35108 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LRkZH-0004nJ-0H for qemu-devel@nongnu.org; Tue, 27 Jan 2009 04:49:15 -0500 Received: from lizzard.sbs.de ([194.138.37.39]:15296) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LRkZG-00015U-D7 for qemu-devel@nongnu.org; Tue, 27 Jan 2009 04:49:14 -0500 Received: from mail1.sbs.de (localhost [127.0.0.1]) by lizzard.sbs.de (8.12.11.20060308/8.12.11) with ESMTP id n0R9nCJj005552 for ; Tue, 27 Jan 2009 10:49:12 +0100 Received: from [139.25.109.167] (mchn012c.mchp.siemens.de [139.25.109.167] (may be forged)) by mail1.sbs.de (8.12.11.20060308/8.12.11) with ESMTP id n0R9nCYx029510 for ; Tue, 27 Jan 2009 10:49:12 +0100 Message-ID: <497ED89C.4070108@siemens.com> Date: Tue, 27 Jan 2009 10:49:16 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <497C9398.3060006@web.de> <497DF491.4010808@codemonkey.ws> <200901261858.19098.paul@codesourcery.com> <497E11F7.7090802@codemonkey.ws> <761ea48b0901270123x211444d2k224c21ba6df1324b@mail.gmail.com> <497ED829.1070906@siemens.com> In-Reply-To: <497ED829.1070906@siemens.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] build system: Further improve quiet mode Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Jan Kiszka wrote: > Laurent Desnogues wrote: >> On Mon, Jan 26, 2009 at 8:41 PM, Anthony Liguori wrote: >>> Paul Brook wrote: >>>>> BTW, what do people think of printing CFLAGS? I find it not all that >>>>> exciting but if people like it, I'm happy to go with it. >>>>> >>>> I don't find it that interesting either. Especially given we use at least >>>> two different sets of CFLAGS, and you really also need to know which >>>> compiler is being invoked. You can always use V=1. >>>> >>> That was my thinking too. The more noise in the build output, the less >>> useful the quiet mode is wrt catching warnings. >> So what about this? >> >> >> Laurent >> >> - Make user-mode build process quieter. >> >> Signed-off-by: Laurent Desnogues >> >> Index: Makefile.target >> =================================================================== >> --- Makefile.target (revision 6463) >> +++ Makefile.target (working copy) >> @@ -725,9 +725,9 @@ >> endif # !CONFIG_USER_ONLY >> >> gdbstub-xml.c: $(TARGET_XML_FILES) feature_to_c.sh >> - rm -f $@ >> + $(call quiet-command,rm -f $@) >> ifeq ($(TARGET_XML_FILES),) >> - echo > $@ >> + $(call quiet-command,echo > $@) >> else >> $(SHELL) $(SRC_PATH)/feature_to_c.sh $@ $(TARGET_XML_FILES) >> endif > > I was thinking in this direction already as well. But please go for a > canonical output, something like > > GENERATE ppc-softmmu/gdbstub-xml.c > > (Likely requires adjusting indention of the other rules.) Or simply use GEN ppc-softmmu/gdbstub-xml.c which fits into the existing layout. Jan -- Siemens AG, Corporate Technology, CT SE 2 Corporate Competence Center Embedded Linux