From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LRowx-0004yk-VA for qemu-devel@nongnu.org; Tue, 27 Jan 2009 09:30:00 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LRowv-0004xn-Qm for qemu-devel@nongnu.org; Tue, 27 Jan 2009 09:29:59 -0500 Received: from [199.232.76.173] (port=46240 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LRowv-0004xh-KR for qemu-devel@nongnu.org; Tue, 27 Jan 2009 09:29:57 -0500 Received: from e38.co.us.ibm.com ([32.97.110.159]:60257) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LRowu-0007pn-Sx for qemu-devel@nongnu.org; Tue, 27 Jan 2009 09:29:57 -0500 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e38.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id n0RESH3v029474 for ; Tue, 27 Jan 2009 07:28:17 -0700 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id n0RETqOI209066 for ; Tue, 27 Jan 2009 07:29:52 -0700 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n0RETqQs012731 for ; Tue, 27 Jan 2009 07:29:52 -0700 Message-ID: <497F1A52.2040106@us.ibm.com> Date: Tue, 27 Jan 2009 08:29:38 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 4/7] block-vpc: Fix support for images > 4 GB References: <1232989168-27759-1-git-send-email-kwolf@suse.de> <1232989168-27759-5-git-send-email-kwolf@suse.de> In-Reply-To: <1232989168-27759-5-git-send-email-kwolf@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf Kevin Wolf wrote: > This patch fixes the truncation of sector offsets to 32 bits. > > Signed-off-by: Kevin Wolf > --- > block-vpc.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/block-vpc.c b/block-vpc.c > index 3c92bb3..51644e6 100644 > --- a/block-vpc.c > +++ b/block-vpc.c > @@ -207,7 +207,7 @@ static inline int seek_to_sector(BlockDriverState *bs, int64_t sector_num) > if (pagetable_index > s->max_table_entries || s->pagetable[pagetable_index] == 0xffffffff) > return -1; // not allocated > > - bitmap_offset = 512 * s->pagetable[pagetable_index]; > + bitmap_offset = 512 * (uint64_t) s->pagetable[pagetable_index]; > block_offset = bitmap_offset + 512 + (512 * pageentry_index); > > // printf("sector: %" PRIx64 ", index: %x, offset: %x, bioff: %" PRIx64 ", bloff: %" PRIx64 "\n", > Applied. Thanks. Regards, Anthony Liguori