From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LRr6n-0008Nb-20 for qemu-devel@nongnu.org; Tue, 27 Jan 2009 11:48:17 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LRr6l-0008Mv-Dv for qemu-devel@nongnu.org; Tue, 27 Jan 2009 11:48:16 -0500 Received: from [199.232.76.173] (port=56019 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LRr6l-0008Mq-63 for qemu-devel@nongnu.org; Tue, 27 Jan 2009 11:48:15 -0500 Received: from qw-out-1920.google.com ([74.125.92.150]:10564) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LRr6k-0003Fs-Pi for qemu-devel@nongnu.org; Tue, 27 Jan 2009 11:48:14 -0500 Received: by qw-out-1920.google.com with SMTP id 5so1290356qwc.4 for ; Tue, 27 Jan 2009 08:48:14 -0800 (PST) Message-ID: <497F3ABE.5000300@codemonkey.ws> Date: Tue, 27 Jan 2009 10:47:58 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Random MAC address option References: <200901270313.26331.pavel@pavlinux.ru> <200901271633.48839.paul@codesourcery.com> In-Reply-To: <200901271633.48839.paul@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pavel@pavlinux.ru Paul Brook wrote: >> + if (strstr(p, "macrandom")) { >> > > I'm not convinced this is a useful feature. > > We already allow the user to specify a mac address, so this feature can be > trivially implemented (and better supported) by a management app or simple > shell script. > > In addition to the issues other people have raised, there's no validation that > the random value is actually a valid mac address, and no conflict resolution > to avoid duplicate addresses when multiple NICs are present. > I agree. It gives a false sense of security. Regards, Anthony Liguori > Paul > > >