From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LSYCR-0000B1-Se for qemu-devel@nongnu.org; Thu, 29 Jan 2009 09:48:59 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LSYCQ-0000A4-Lh for qemu-devel@nongnu.org; Thu, 29 Jan 2009 09:48:59 -0500 Received: from [199.232.76.173] (port=52993 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LSYCQ-00009x-HR for qemu-devel@nongnu.org; Thu, 29 Jan 2009 09:48:58 -0500 Received: from smtp.eu.citrix.com ([62.200.22.115]:62478) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LSYCQ-0004pj-3D for qemu-devel@nongnu.org; Thu, 29 Jan 2009 09:48:58 -0500 Message-ID: <4981BFD0.8020006@eu.citrix.com> Date: Thu, 29 Jan 2009 14:40:16 +0000 From: Stefano Stabellini MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH] fix raw_aio_read\write error handling Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Currently when qemu_paio_read or qemu_paio_write return an error we call qemu_aio_release without removing the request from the list. I know that in the current implementation qemu_paio_write\read don't return any error, but still the behavior is wrong, especially considering that the implementation of these two functions is likely to change in is the future. This patch fixes the problem adding a raw_aio_remove function that removes the callback from the queue and also calls qemu_aio_release. raw_aio_remove is called by raw_aio_read, raw_aio_write and raw_aio_cancel. Signed-off-by: Stefano Stabellini --- diff --git a/block-raw-posix.c b/block-raw-posix.c index 4404eb1..ac88fc3 100644 --- a/block-raw-posix.c +++ b/block-raw-posix.c @@ -598,6 +598,24 @@ static void raw_aio_em_cb(void* opaque) qemu_aio_release(acb); } +static void raw_aio_remove(RawAIOCB *acb) +{ + RawAIOCB **pacb; + + /* remove the callback from the queue */ + pacb = &posix_aio_state->first_aio; + for(;;) { + if (*pacb == NULL) { + break; + } else if (*pacb == acb) { + *pacb = acb->next; + qemu_aio_release(acb); + break; + } + pacb = &acb->next; + } +} + static BlockDriverAIOCB *raw_aio_read(BlockDriverState *bs, int64_t sector_num, uint8_t *buf, int nb_sectors, BlockDriverCompletionFunc *cb, void *opaque) @@ -623,7 +641,7 @@ static BlockDriverAIOCB *raw_aio_read(BlockDriverState *bs, if (!acb) return NULL; if (qemu_paio_read(&acb->aiocb) < 0) { - qemu_aio_release(acb); + raw_aio_remove(acb); return NULL; } return &acb->common; @@ -654,7 +672,7 @@ static BlockDriverAIOCB *raw_aio_write(BlockDriverState *bs, if (!acb) return NULL; if (qemu_paio_write(&acb->aiocb) < 0) { - qemu_aio_release(acb); + raw_aio_remove(acb); return NULL; } return &acb->common; @@ -664,7 +682,6 @@ static void raw_aio_cancel(BlockDriverAIOCB *blockacb) { int ret; RawAIOCB *acb = (RawAIOCB *)blockacb; - RawAIOCB **pacb; ret = qemu_paio_cancel(acb->aiocb.aio_fildes, &acb->aiocb); if (ret == QEMU_PAIO_NOTCANCELED) { @@ -673,18 +690,7 @@ static void raw_aio_cancel(BlockDriverAIOCB *blockacb) while (qemu_paio_error(&acb->aiocb) == EINPROGRESS); } - /* remove the callback from the queue */ - pacb = &posix_aio_state->first_aio; - for(;;) { - if (*pacb == NULL) { - break; - } else if (*pacb == acb) { - *pacb = acb->next; - qemu_aio_release(acb); - break; - } - pacb = &acb->next; - } + raw_aio_remove(acb); } #else /* CONFIG_AIO */ static int posix_aio_init(void)