From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LSYaE-0004sO-GO
	for qemu-devel@nongnu.org; Thu, 29 Jan 2009 10:13:34 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LSYaC-0004r3-Jy
	for qemu-devel@nongnu.org; Thu, 29 Jan 2009 10:13:33 -0500
Received: from [199.232.76.173] (port=51329 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LSYaC-0004qw-Fv
	for qemu-devel@nongnu.org; Thu, 29 Jan 2009 10:13:32 -0500
Received: from an-out-0708.google.com ([209.85.132.241]:17972)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1LSYaC-0007mp-9P
	for qemu-devel@nongnu.org; Thu, 29 Jan 2009 10:13:32 -0500
Received: by an-out-0708.google.com with SMTP id b6so1950705ana.37
	for <qemu-devel@nongnu.org>; Thu, 29 Jan 2009 07:13:31 -0800 (PST)
Message-ID: <4981C78C.3050309@codemonkey.ws>
Date: Thu, 29 Jan 2009 09:13:16 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1233228298-4844-1-git-send-email-agraf@suse.de>
	<1233228298-4844-2-git-send-email-agraf@suse.de>
	<1233228298-4844-3-git-send-email-agraf@suse.de>
	<1233228298-4844-4-git-send-email-agraf@suse.de>
	<1233228298-4844-5-git-send-email-agraf@suse.de>
	<1233228298-4844-6-git-send-email-agraf@suse.de>
	<1233228298-4844-7-git-send-email-agraf@suse.de>
In-Reply-To: <1233228298-4844-7-git-send-email-agraf@suse.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 6/7] Add tight protocol awareness to vnc.c
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-devel@nongnu.org

Alexander Graf wrote:
> This patch enables the vnc server to understand the tight protocol.
>
> Basically, negotiation if tight is existing happens through the
> authentication code. If a special authentication called VNC_AUTH_TIGHT
> is used, the real authentication is stacked afterwards and tight
> extensions exist.
>   

This is wrong.  The way the standard works is that the client advertises 
the Tight encoding via SetEncodingTypes.  That's all that should be 
needed.  The VNC_AUTH_TIGHT thing is a Tight extension that shouldn't be 
needed for implementing tight encoding.

Regards,

Anthony Liguori