From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LSYrz-0002Jx-8j
	for qemu-devel@nongnu.org; Thu, 29 Jan 2009 10:31:55 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LSYrx-0002Ix-IN
	for qemu-devel@nongnu.org; Thu, 29 Jan 2009 10:31:54 -0500
Received: from [199.232.76.173] (port=60247 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LSYrx-0002It-Ct
	for qemu-devel@nongnu.org; Thu, 29 Jan 2009 10:31:53 -0500
Received: from smtp.eu.citrix.com ([62.200.22.115]:4946)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <Stefano.Stabellini@eu.citrix.com>)
	id 1LSYrx-0002M5-1s
	for qemu-devel@nongnu.org; Thu, 29 Jan 2009 10:31:53 -0500
Message-ID: <4981C9E0.6050708@eu.citrix.com>
Date: Thu, 29 Jan 2009 15:23:12 +0000
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH 7/7] Add tight encoding (jpeg) to vnc.c
References: <1233228298-4844-1-git-send-email-agraf@suse.de>	<1233228298-4844-2-git-send-email-agraf@suse.de>	<1233228298-4844-3-git-send-email-agraf@suse.de>	<1233228298-4844-4-git-send-email-agraf@suse.de>	<1233228298-4844-5-git-send-email-agraf@suse.de>	<1233228298-4844-6-git-send-email-agraf@suse.de>	<1233228298-4844-7-git-send-email-agraf@suse.de>	<1233228298-4844-8-git-send-email-agraf@suse.de>
	<4981C8A2.8070405@codemonkey.ws>
In-Reply-To: <4981C8A2.8070405@codemonkey.ws>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Alexander Graf <agraf@suse.de>

Anthony Liguori wrote:

> If we implement Tight and then use jpeg by default, for most clients,
> the default is going to be lossy encoding.  While lossy isn't so bad for
> high detailed images (like pictures), it's pretty terrible for simple,
> high contrast images (like windows in a desktop).
> 
> TightVNC has some sophisticated heuristics for determining whether to
> use jpeg or not (when it's enabled).  I think that sort of heuristic is
> a prerequisite for enabling tight's jpeg support.
> 
> FWIW, Tight essentially does hextile encoding but adds zlib
> compression.  That's probably a better place to start as it should
> outperform hextile while remaining lossless.
> 

Another thing to consider is that using jpeg compression is going to
worsen qemu performances, so I think it should be used only when
necessary, e.g. the network connection between client and server is  bad.