From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LSYkx-0007m1-I2
	for qemu-devel@nongnu.org; Thu, 29 Jan 2009 10:24:39 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LSYkw-0007lU-K4
	for qemu-devel@nongnu.org; Thu, 29 Jan 2009 10:24:39 -0500
Received: from [199.232.76.173] (port=54688 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LSYkw-0007lP-Cs
	for qemu-devel@nongnu.org; Thu, 29 Jan 2009 10:24:38 -0500
Received: from ns.suse.de ([195.135.220.2]:58127 helo=mx1.suse.de)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <agraf@suse.de>) id 1LSYkw-0001IH-2T
	for qemu-devel@nongnu.org; Thu, 29 Jan 2009 10:24:38 -0500
Message-ID: <4981CA32.3080108@suse.de>
Date: Thu, 29 Jan 2009 16:24:34 +0100
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <1233228298-4844-1-git-send-email-agraf@suse.de>
	<1233228298-4844-2-git-send-email-agraf@suse.de>
	<1233228298-4844-3-git-send-email-agraf@suse.de>
	<1233228298-4844-4-git-send-email-agraf@suse.de>
	<1233228298-4844-5-git-send-email-agraf@suse.de>
	<1233228298-4844-6-git-send-email-agraf@suse.de>
	<1233228298-4844-7-git-send-email-agraf@suse.de>
	<4981C78C.3050309@codemonkey.ws>
In-Reply-To: <4981C78C.3050309@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 6/7] Add tight protocol awareness to vnc.c
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org

Anthony Liguori wrote:
> Alexander Graf wrote:
>> This patch enables the vnc server to understand the tight protocol.
>>
>> Basically, negotiation if tight is existing happens through the
>> authentication code. If a special authentication called VNC_AUTH_TIGHT
>> is used, the real authentication is stacked afterwards and tight
>> extensions exist.
>>   
>
> This is wrong.  The way the standard works is that the client
> advertises the Tight encoding via SetEncodingTypes.  That's all that
> should be needed.  The VNC_AUTH_TIGHT thing is a Tight extension that
> shouldn't be needed for implementing tight encoding.

So how am I supposed to do the write_tight_interaction_capabilities()
thing? I don't see how we advertise to the guest that we do support
tight encoding if we can't tell it that we do.

Alex
>
> Regards,
>
> Anthony Liguori