[Qemu-devel] Re: [PATCH 6/7] Add tight protocol awareness to vnc.c

[Anthony Liguori <anthony@codemonkey.ws>]

Alexander Graf wrote:
> Anthony Liguori wrote:
>   
>> Alexander Graf wrote:
>>     
>>> This patch enables the vnc server to understand the tight protocol.
>>>
>>> Basically, negotiation if tight is existing happens through the
>>> authentication code. If a special authentication called VNC_AUTH_TIGHT
>>> is used, the real authentication is stacked afterwards and tight
>>> extensions exist.
>>>   
>>>       
>> This is wrong.  The way the standard works is that the client
>> advertises the Tight encoding via SetEncodingTypes.  That's all that
>> should be needed.  The VNC_AUTH_TIGHT thing is a Tight extension that
>> shouldn't be needed for implementing tight encoding.
>>     
>
> So how am I supposed to do the write_tight_interaction_capabilities()
> thing? I don't see how we advertise to the guest that we do support
> tight encoding if we can't tell it that we do.
>   

The server doesn't advertise encodings to the client.  The client 
advertises supported encodings to the server and the server chooses to 
use whatever one it would like to (that is supports).  A server is 
supposed to ignore encodings that it doesn't know about.

Regards,

Anthony Liguori

> Alex
>   
>> Regards,
>>
>> Anthony Liguori
>>     
>
>