From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LSZ3G-0005Qd-IQ for qemu-devel@nongnu.org; Thu, 29 Jan 2009 10:43:34 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LSZ3E-0005Ps-Ti for qemu-devel@nongnu.org; Thu, 29 Jan 2009 10:43:33 -0500 Received: from [199.232.76.173] (port=52782 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LSZ3D-0005Pe-CJ for qemu-devel@nongnu.org; Thu, 29 Jan 2009 10:43:31 -0500 Received: from mail-qy0-f20.google.com ([209.85.221.20]:60213) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LSZ3D-0003w8-3V for qemu-devel@nongnu.org; Thu, 29 Jan 2009 10:43:31 -0500 Received: by qyk13 with SMTP id 13so12464852qyk.10 for ; Thu, 29 Jan 2009 07:43:30 -0800 (PST) Message-ID: <4981CE92.6020602@codemonkey.ws> Date: Thu, 29 Jan 2009 09:43:14 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1233228298-4844-1-git-send-email-agraf@suse.de> <1233228298-4844-2-git-send-email-agraf@suse.de> <1233228298-4844-3-git-send-email-agraf@suse.de> <1233228298-4844-4-git-send-email-agraf@suse.de> <1233228298-4844-5-git-send-email-agraf@suse.de> <1233228298-4844-6-git-send-email-agraf@suse.de> <1233228298-4844-7-git-send-email-agraf@suse.de> <4981C78C.3050309@codemonkey.ws> <4981CA32.3080108@suse.de> In-Reply-To: <4981CA32.3080108@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 6/7] Add tight protocol awareness to vnc.c Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-devel@nongnu.org Alexander Graf wrote: > Anthony Liguori wrote: > >> Alexander Graf wrote: >> >>> This patch enables the vnc server to understand the tight protocol. >>> >>> Basically, negotiation if tight is existing happens through the >>> authentication code. If a special authentication called VNC_AUTH_TIGHT >>> is used, the real authentication is stacked afterwards and tight >>> extensions exist. >>> >>> >> This is wrong. The way the standard works is that the client >> advertises the Tight encoding via SetEncodingTypes. That's all that >> should be needed. The VNC_AUTH_TIGHT thing is a Tight extension that >> shouldn't be needed for implementing tight encoding. >> > > So how am I supposed to do the write_tight_interaction_capabilities() > thing? I don't see how we advertise to the guest that we do support > tight encoding if we can't tell it that we do. > The server doesn't advertise encodings to the client. The client advertises supported encodings to the server and the server chooses to use whatever one it would like to (that is supports). A server is supposed to ignore encodings that it doesn't know about. Regards, Anthony Liguori > Alex > >> Regards, >> >> Anthony Liguori >> > >