From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LSaIM-0000qW-TE
	for qemu-devel@nongnu.org; Thu, 29 Jan 2009 12:03:15 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LSaIH-0000lj-Cm
	for qemu-devel@nongnu.org; Thu, 29 Jan 2009 12:03:13 -0500
Received: from [199.232.76.173] (port=59304 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LSaIH-0000lW-1v
	for qemu-devel@nongnu.org; Thu, 29 Jan 2009 12:03:09 -0500
Received: from e3.ny.us.ibm.com ([32.97.182.143]:58616)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <aliguori@us.ibm.com>) id 1LSaIG-0005q7-Fz
	for qemu-devel@nongnu.org; Thu, 29 Jan 2009 12:03:08 -0500
Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234])
	by e3.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n0TH19oZ031422
	for <qemu-devel@nongnu.org>; Thu, 29 Jan 2009 12:01:09 -0500
Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64])
	by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id
	n0TH2uvh130372
	for <qemu-devel@nongnu.org>; Thu, 29 Jan 2009 12:03:00 -0500
Received: from d01av04.pok.ibm.com (loopback [127.0.0.1])
	by d01av04.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
	n0TH2tfR011849
	for <qemu-devel@nongnu.org>; Thu, 29 Jan 2009 12:02:55 -0500
Received: from squirrel.codemonkey.ws (sig-9-65-71-35.mts.ibm.com [9.65.71.35])
	by d01av04.pok.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id
	n0TH2pLH011512
	for <qemu-devel@nongnu.org>; Thu, 29 Jan 2009 12:02:52 -0500
Message-ID: <4981E12E.3030100@us.ibm.com>
Date: Thu, 29 Jan 2009 11:02:38 -0600
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] MTRR support on x86, part 2
References: <497E4A30.7070103@gmx.net>
In-Reply-To: <497E4A30.7070103@gmx.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Carl-Daniel Hailfinger wrote:
> Load and save MTRR state together with machine state.
>
> Add support for the MTRRcap MSR which is used by the latest Bochs BIOS
> and some operating systems.
>
> Fix a typo in ext2_feature_name.
>
> With this patch, MTRR emulation should be good enough to not trigger any
> sanity checks in well behaved BIOS/kernel code.
> Some corner cases for BIOS/firmware usage remain to be implemented, but
> that can be deferred to another patch.
> Also, MTRR accesses on hardware not supporting MTRRs should cause #GP.
> That can be enforced by another patch as well.
>
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
>
> Index: target-i386/helper.c
> ===================================================================
> --- target-i386/helper.c	(Revision 6461)
> +++ target-i386/helper.c	(Arbeitskopie)
> @@ -55,7 +55,7 @@
>      };
>      static const char *ext2_feature_name[] = {
>         "fpu", "vme", "de", "pse", "tsc", "msr", "pae", "mce",
> -       "cx8" /* AMD CMPXCHG8B */, "apic", NULL, "syscall", "mttr", "pge", "mca", "cmov",
> +       "cx8" /* AMD CMPXCHG8B */, "apic", NULL, "syscall", "mtrr", "pge", "mca", "cmov",
>   

As best as I can tell, there is no change here.  I removed it from the 
diff and applied the rest.

Thanks.

Regards,

Anthony Liguori
>         "pat"