From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LScca-0006aj-D5
	for qemu-devel@nongnu.org; Thu, 29 Jan 2009 14:32:16 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LSccY-0006Zg-HL
	for qemu-devel@nongnu.org; Thu, 29 Jan 2009 14:32:15 -0500
Received: from [199.232.76.173] (port=37794 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LSccY-0006ZY-B8
	for qemu-devel@nongnu.org; Thu, 29 Jan 2009 14:32:14 -0500
Received: from mail.gmx.net ([213.165.64.20]:43976)
	by monty-python.gnu.org with smtp (Exim 4.60)
	(envelope-from <c-d.hailfinger.devel.2006@gmx.net>)
	id 1LSccX-0005f1-4O
	for qemu-devel@nongnu.org; Thu, 29 Jan 2009 14:32:14 -0500
Message-ID: <49820443.9040606@gmx.net>
Date: Thu, 29 Jan 2009 20:32:19 +0100
From: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] MTRR support on x86, part 2
References: <497E4A30.7070103@gmx.net> <4981E12E.3030100@us.ibm.com>
In-Reply-To: <4981E12E.3030100@us.ibm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 29.01.2009 18:02, Anthony Liguori wrote:
> Carl-Daniel Hailfinger wrote:
>> Load and save MTRR state together with machine state.
>>
>> Add support for the MTRRcap MSR which is used by the latest Bochs BIOS
>> and some operating systems.
>>
>> Fix a typo in ext2_feature_name.
>>
>> With this patch, MTRR emulation should be good enough to not trigger any
>> sanity checks in well behaved BIOS/kernel code.
>> Some corner cases for BIOS/firmware usage remain to be implemented, but
>> that can be deferred to another patch.
>> Also, MTRR accesses on hardware not supporting MTRRs should cause #GP.
>> That can be enforced by another patch as well.
>>
>> Signed-off-by: Carl-Daniel Hailfinger
>> <c-d.hailfinger.devel.2006@gmx.net>

Thanks for applying the patch!

>> Index: target-i386/helper.c
>> ===================================================================
>> --- target-i386/helper.c    (Revision 6461)
>> +++ target-i386/helper.c    (Arbeitskopie)
>> @@ -55,7 +55,7 @@
>>      };
>>      static const char *ext2_feature_name[] = {
>>         "fpu", "vme", "de", "pse", "tsc", "msr", "pae", "mce",
>> -       "cx8" /* AMD CMPXCHG8B */, "apic", NULL, "syscall", "mttr",
>> "pge", "mca", "cmov",
>> +       "cx8" /* AMD CMPXCHG8B */, "apic", NULL, "syscall", "mtrr",
>> "pge", "mca", "cmov",
>>   
>
> As best as I can tell, there is no change here.  I removed it from the
> diff and applied the rest.

It was mtTr, but it should have been mtRr (emphasis mine).

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/