From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LScsQ-0003ip-Ub
	for qemu-devel@nongnu.org; Thu, 29 Jan 2009 14:48:38 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LScsP-0003iF-Dy
	for qemu-devel@nongnu.org; Thu, 29 Jan 2009 14:48:38 -0500
Received: from [199.232.76.173] (port=40999 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LScsP-0003iA-8o
	for qemu-devel@nongnu.org; Thu, 29 Jan 2009 14:48:37 -0500
Received: from qw-out-1920.google.com ([74.125.92.144]:1203)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1LScsO-00079w-TR
	for qemu-devel@nongnu.org; Thu, 29 Jan 2009 14:48:37 -0500
Received: by qw-out-1920.google.com with SMTP id 5so26407qwc.4
	for <qemu-devel@nongnu.org>; Thu, 29 Jan 2009 11:48:36 -0800 (PST)
Message-ID: <49820804.5070602@codemonkey.ws>
Date: Thu, 29 Jan 2009 13:48:20 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] MTRR support on x86, part 2
References: <497E4A30.7070103@gmx.net> <4981E12E.3030100@us.ibm.com>
	<49820443.9040606@gmx.net>
In-Reply-To: <49820443.9040606@gmx.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Carl-Daniel Hailfinger wrote:
> On 29.01.2009 18:02, Anthony Liguori wrote:
>   
>> Carl-Daniel Hailfinger wrote:
>>     
>>> Load and save MTRR state together with machine state.
>>>
>>> Add support for the MTRRcap MSR which is used by the latest Bochs BIOS
>>> and some operating systems.
>>>
>>> Fix a typo in ext2_feature_name.
>>>
>>> With this patch, MTRR emulation should be good enough to not trigger any
>>> sanity checks in well behaved BIOS/kernel code.
>>> Some corner cases for BIOS/firmware usage remain to be implemented, but
>>> that can be deferred to another patch.
>>> Also, MTRR accesses on hardware not supporting MTRRs should cause #GP.
>>> That can be enforced by another patch as well.
>>>
>>> Signed-off-by: Carl-Daniel Hailfinger
>>> <c-d.hailfinger.devel.2006@gmx.net>
>>>       
>
> Thanks for applying the patch!
>
>   
>>> Index: target-i386/helper.c
>>> ===================================================================
>>> --- target-i386/helper.c    (Revision 6461)
>>> +++ target-i386/helper.c    (Arbeitskopie)
>>> @@ -55,7 +55,7 @@
>>>      };
>>>      static const char *ext2_feature_name[] = {
>>>         "fpu", "vme", "de", "pse", "tsc", "msr", "pae", "mce",
>>> -       "cx8" /* AMD CMPXCHG8B */, "apic", NULL, "syscall", "mttr",
>>> "pge", "mca", "cmov",
>>> +       "cx8" /* AMD CMPXCHG8B */, "apic", NULL, "syscall", "mtrr",
>>> "pge", "mca", "cmov",
>>>   
>>>       
>> As best as I can tell, there is no change here.  I removed it from the
>> diff and applied the rest.
>>     
>
> It was mtTr, but it should have been mtRr (emphasis mine).
>   

Yeah, sorry.  In general, it's better to split multiple fixes into 
multiple patches to make it clear.  I should have bounced the patch 
instead of removing that chunk though. Then my mistake would have been 
more obvious.  Sorry again for that.

Regards,

Anthony Liguori

> Regards,
> Carl-Daniel
>
>