From: Anthony Liguori <aliguori@us.ibm.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] check SCSI read/write requests against max LBA
Date: Thu, 29 Jan 2009 13:59:16 -0600 [thread overview]
Message-ID: <49820A94.7010207@us.ibm.com> (raw)
In-Reply-To: <20090129115456.2593238b@bree.surriel.com>
Rik van Riel wrote:
> The bdrv layer uses a signed offset. Furthermore, block-raw-posix
> only seeks when that offset is positive. Passing a negative offset
> to block-raw-posix can result in data being written at the current
> seek cursor's position.
>
> It may be possible to exploit this to seek to the end of the disk
> and extend the virtual disk by writing data to a negative sector
> offset. After a reboot, this could lead to the guest having a
> larger disk than it had before.
>
> Close the hole by sanity checking the lba against the size of the
> disk.
>
> Signed-off-by: Rik van Riel <riel@redhat.com>
>
Applied. Thanks.
Regards,
Anthony Liguori
prev parent reply other threads:[~2009-01-29 19:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-29 16:54 [Qemu-devel] [PATCH] check SCSI read/write requests against max LBA Rik van Riel
2009-01-29 19:59 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49820A94.7010207@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).