qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "René Rebe" <rene@exactcode.de>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] fix loading tiny kernels
Date: Tue, 03 Feb 2009 09:59:31 +0100	[thread overview]
Message-ID: <49880773.5000203@exactcode.de> (raw)

Further testing / polishing the multi-boot kernel loading support I found
the existing code fails to load unusual small kernels, less than 8192 
bytes -
for example the example multi-boot kernel shipped within GRUB that
compiles to just 7121 bytes on my system.

Signed-off-by: René Rebe <rene@exactcode.de>

--- hw/pc.c     (revision 6501)
+++ hw/pc.c     (working copy)
@@ -554,7 +989,7 @@
     /* load the kernel header */
     f = fopen(kernel_filename, "rb");
     if (!f || !(kernel_size = get_file_size(f)) ||
-    fread(header, 1, 1024, f) != 1024) {
+    fread(header, 1, MIN(8192, kernel_size), f) != MIN(8192, 
kernel_size)) {
     fprintf(stderr, "qemu: could not load kernel '%s'\n",
         kernel_filename);
     exit(1);

-- 
  René Rebe - ExactCODE GmbH - Europe, Germany, Berlin
  http://exactcode.de | http://t2-project.org | http://rene.rebe.name

             reply	other threads:[~2009-02-03  8:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-03  8:59 René Rebe [this message]
2009-02-03  9:05 ` [Qemu-devel] [PATCH] fix loading tiny kernels Laurent Desnogues
2009-02-03  9:06 ` René Rebe
2009-02-03 10:30   ` Daniel P. Berrange
2009-02-03 11:09     ` Alexander Graf
2009-02-03 12:31       ` Rene Rebe
2009-02-03 12:33         ` Alexander Graf
2009-02-03 13:30       ` Daniel P. Berrange
2009-02-03 14:02         ` Rene Rebe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49880773.5000203@exactcode.de \
    --to=rene@exactcode.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).