From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LUKRK-0005Fu-N8
	for qemu-devel@nongnu.org; Tue, 03 Feb 2009 07:31:42 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LUKRG-0005DX-Sr
	for qemu-devel@nongnu.org; Tue, 03 Feb 2009 07:31:42 -0500
Received: from [199.232.76.173] (port=49385 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LUKRG-0005DT-Oe
	for qemu-devel@nongnu.org; Tue, 03 Feb 2009 07:31:38 -0500
Received: from yx-out-1718.google.com ([74.125.44.155]:10030)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1LUKRF-00008I-R7
	for qemu-devel@nongnu.org; Tue, 03 Feb 2009 07:31:38 -0500
Received: by yx-out-1718.google.com with SMTP id 3so916536yxi.82
	for <qemu-devel@nongnu.org>; Tue, 03 Feb 2009 04:31:37 -0800 (PST)
Message-ID: <49883914.2030904@codemonkey.ws>
Date: Tue, 03 Feb 2009 06:31:16 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] QEMU SVN on Windows 2000 :-(
References: <49876B4C.9090806@bttr-software.de>	<498773B6.7060301@codemonkey.ws>
	<4987F7F1.2040104@redhat.com>
In-Reply-To: <4987F7F1.2040104@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Avi Kivity wrote:
> Anthony Liguori wrote:
>> Robert Riebisch wrote:
>>> Hi!
>>>
>>> Unfortunately Win32 binaries built from QEMU SVN don't run on Windows
>>> 2000 anymore, because of missing DLL entry points in `ws2_32.dll'.
>>>   
>>
>> Unfortunately, win2k is so old at this point, that I don't know that 
>> it's worth jumping through hoops to support.
>>
>> If someone can come up with a simple patch (with appropriately 
>> licensed code), then I'd be happy to apply it.  Otherwise, I don't 
>> think not supporting win2k as a host is a huge loss.
>>
>
> There is in fact a signed-off two-liner still in the thread:

"but it requires copyrighted file `Wspiapi.h' from MSVC2005, because 
MinGW doesn't provide such a file."

So if Wspiapi.h carries a GPL compatible license, it's fine to include.  
The patch lacks Wspiapi.h though so it'll break the build on mingw.

Regards,

Anthony Liguori

>>>
>>> --- qemu-sockets.c.orig    Wed Jan 14 19:34:22 2009
>>> +++ qemu-sockets.c    Mon Feb 02 22:04:42 2009
>>> @@ -22,6 +22,9 @@
>>>  #include "qemu_socket.h"
>>>  #include "qemu-common.h" /* for qemu_isdigit */
>>>
>>> +#define _inline __inline /* circumvent header file issue */
>>> +#include <wspiapi.h>
>>> +
>>>  #ifndef AI_ADDRCONFIG
>>>  # define AI_ADDRCONFIG 0
>>>  #endif
>>> ***
>>>
>>> Signed-off-by: Robert Riebisch <rr@bttr-software.de>
>
>