qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Rene Rebe <rene@exactcode.de>
To: qemu-devel@nongnu.org
Cc: Alexander Graf <agraf@suse.de>, paul@codesourcery.com
Subject: Re: [Qemu-devel] [PATCH] Add multi-boot kernel loading support
Date: Tue, 03 Feb 2009 15:00:57 +0100	[thread overview]
Message-ID: <49884E19.9070909@exactcode.de> (raw)
In-Reply-To: <200902031301.32385.paul@codesourcery.com>

Paul Brook wrote:
> On Monday 02 February 2009, Rene Rebe wrote:
>> Hi all,
>>
>> Alexander Graf implemented multi-boot kernel loading during
>> his work to run Darwin inside Qemu/KVM. As the boot loader
>> expects to load the kernel in an EFI environment a custom
>> booter is used to load the kernel using a legacy BIOS.
>>
>> This is a port of the patch to the new extload / INT 19
>> machinery (including minor cleanups).
> 
> This is introducing quite a lot of nontrivial target code in a hard to 
> understand and maintain way. This seems like a bad idea.
> 
> I suspect it would be better to implement this as an actual boot rom, and have 
> it read arguments from the firmware device. Ideally the same rom would also 
> cover the linux kernel case.

Hm. As I'm not yet memorized the Qemu code and and build system
maybe someone wants to shape the existing option rom code
in the way envisioned to base this patch series on?

Another option would also to apply (a cleaned up) version
of the patch as it is quite local and intrusive code and
someone else further re-factors it into an externally built
option rom?


Greetings,

-- 
   René Rebe - ExactCODE GmbH - Europe, Germany, Berlin
   http://exactcode.de | http://t2-project.org | http://rene.rebe.name

      reply	other threads:[~2009-02-03 14:01 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-02 18:08 [Qemu-devel] [PATCH] Add multi-boot kernel loading support Rene Rebe
2009-02-02 18:15 ` Nathan Froyd
2009-02-02 18:17   ` Alexander Graf
2009-02-02 18:25     ` Nathan Froyd
2009-02-02 22:42 ` Anthony Liguori
2009-02-03  8:15   ` Rene Rebe
2009-02-03  8:23     ` Alexander Graf
2009-02-03  8:27       ` Rene Rebe
2009-02-03  8:25   ` Alexander Graf
2009-02-03  8:29     ` Rene Rebe
2009-02-03 10:53     ` Jamie Lokier
2009-02-03 11:12       ` Alexander Graf
2009-02-03 12:58 ` Kevin Wolf
2009-02-03 13:57   ` Rene Rebe
2009-02-03 14:31     ` Kevin Wolf
2009-02-04 10:36       ` Rene Rebe
2009-02-04 13:05         ` Kevin Wolf
2009-02-03 13:01 ` Paul Brook
2009-02-03 14:00   ` Rene Rebe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49884E19.9070909@exactcode.de \
    --to=rene@exactcode.de \
    --cc=agraf@suse.de \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).