[Qemu-devel] QEMU SVN on Windows 2000 :-(

[Qemu-devel] QEMU SVN on Windows 2000 :-(

[Robert Riebisch]

Hi!

Unfortunately Win32 binaries built from QEMU SVN don't run on Windows
2000 anymore, because of missing DLL entry points in `ws2_32.dll'.

With the introduction of IPv6 QEMU relies on the presence of
getaddrinfo(), getnameinfo(), and freeaddrinfo(). This is OK for Windows
XP or later, but not for Windows 2000.

>From <http://msdn.microsoft.com/en-us/library/ms738520(VS.85).aspx>:
***
*Support for getaddrinfo on older versions of Windows*

The getaddrinfo function was added to the Ws2_32.dll on Windows XP and
later. To execute an application that uses this function on earlier
versions of Windows, then you need to include the Ws2tcpip.h and
Wspiapi.h files. When the Wspiapi.h include file is added, the
getaddrinfo function is defined to the WspiapiGetAddrInfo inline
function in the Wspiapi.h file. At runtime, the WspiapiGetAddrInfo
function is implemented in such a way that if the Ws2_32.dll or the
Wship6.dll (the file containing getaddrinfo in the IPv6 Technology
Preview for Windows 2000) does not include getaddrinfo, then a version
of getaddrinfo is implemented inline based on code in the Wspiapi.h
header file. This inline code will be used on older Windows platforms
that do not natively support the getaddrinfo function.

The IPv6 protocol is supported on Windows 2000 when the IPv6 Technology
Preview for Windows 2000 is installed. Otherwise getaddrinfo support on
versions of Windows earlier than Windows XP is limited to handling IPv4
name resolution.
***

This stupid little patch works for me, but it requires copyrighted file
`Wspiapi.h' from MSVC2005, because MinGW doesn't provide such a file.
I've tested this on Windows 2000 only with IPv4. Better solutions are
highly appreciated.

***
--- qemu-sockets.c.orig	Wed Jan 14 19:34:22 2009
+++ qemu-sockets.c	Mon Feb 02 22:04:42 2009
@@ -22,6 +22,9 @@
 #include "qemu_socket.h"
 #include "qemu-common.h" /* for qemu_isdigit */

+#define _inline __inline /* circumvent header file issue */
+#include <wspiapi.h>
+
 #ifndef AI_ADDRCONFIG
 # define AI_ADDRCONFIG 0
 #endif
***

Signed-off-by: Robert Riebisch <rr@bttr-software.de>

Robert Riebisch
-- 
BTTR Software
http://www.bttr-software.de/

Re: [Qemu-devel] QEMU SVN on Windows 2000 :-(

[Anthony Liguori]

Robert Riebisch wrote:
> Hi!
>
> Unfortunately Win32 binaries built from QEMU SVN don't run on Windows
> 2000 anymore, because of missing DLL entry points in `ws2_32.dll'.
>   

Unfortunately, win2k is so old at this point, that I don't know that 
it's worth jumping through hoops to support.

If someone can come up with a simple patch (with appropriately licensed 
code), then I'd be happy to apply it.  Otherwise, I don't think not 
supporting win2k as a host is a huge loss.

Regards,

Anthony Liguori

> With the introduction of IPv6 QEMU relies on the presence of
> getaddrinfo(), getnameinfo(), and freeaddrinfo(). This is OK for Windows
> XP or later, but not for Windows 2000.
>
> From <http://msdn.microsoft.com/en-us/library/ms738520(VS.85).aspx>:
> ***
> *Support for getaddrinfo on older versions of Windows*
>
> The getaddrinfo function was added to the Ws2_32.dll on Windows XP and
> later. To execute an application that uses this function on earlier
> versions of Windows, then you need to include the Ws2tcpip.h and
> Wspiapi.h files. When the Wspiapi.h include file is added, the
> getaddrinfo function is defined to the WspiapiGetAddrInfo inline
> function in the Wspiapi.h file. At runtime, the WspiapiGetAddrInfo
> function is implemented in such a way that if the Ws2_32.dll or the
> Wship6.dll (the file containing getaddrinfo in the IPv6 Technology
> Preview for Windows 2000) does not include getaddrinfo, then a version
> of getaddrinfo is implemented inline based on code in the Wspiapi.h
> header file. This inline code will be used on older Windows platforms
> that do not natively support the getaddrinfo function.
>
> The IPv6 protocol is supported on Windows 2000 when the IPv6 Technology
> Preview for Windows 2000 is installed. Otherwise getaddrinfo support on
> versions of Windows earlier than Windows XP is limited to handling IPv4
> name resolution.
> ***
>
> This stupid little patch works for me, but it requires copyrighted file
> `Wspiapi.h' from MSVC2005, because MinGW doesn't provide such a file.
> I've tested this on Windows 2000 only with IPv4. Better solutions are
> highly appreciated.
>
> ***
> --- qemu-sockets.c.orig	Wed Jan 14 19:34:22 2009
> +++ qemu-sockets.c	Mon Feb 02 22:04:42 2009
> @@ -22,6 +22,9 @@
>  #include "qemu_socket.h"
>  #include "qemu-common.h" /* for qemu_isdigit */
>
> +#define _inline __inline /* circumvent header file issue */
> +#include <wspiapi.h>
> +
>  #ifndef AI_ADDRCONFIG
>  # define AI_ADDRCONFIG 0
>  #endif
> ***
>
> Signed-off-by: Robert Riebisch <rr@bttr-software.de>
>
> Robert Riebisch
>   

Re: [Qemu-devel] QEMU SVN on Windows 2000 :-(

[Avi Kivity]

Anthony Liguori wrote:
> Robert Riebisch wrote:
>> Hi!
>>
>> Unfortunately Win32 binaries built from QEMU SVN don't run on Windows
>> 2000 anymore, because of missing DLL entry points in `ws2_32.dll'.
>>   
>
> Unfortunately, win2k is so old at this point, that I don't know that 
> it's worth jumping through hoops to support.
>
> If someone can come up with a simple patch (with appropriately 
> licensed code), then I'd be happy to apply it.  Otherwise, I don't 
> think not supporting win2k as a host is a huge loss.
>

There is in fact a signed-off two-liner still in the thread:

>>
>> --- qemu-sockets.c.orig    Wed Jan 14 19:34:22 2009
>> +++ qemu-sockets.c    Mon Feb 02 22:04:42 2009
>> @@ -22,6 +22,9 @@
>>  #include "qemu_socket.h"
>>  #include "qemu-common.h" /* for qemu_isdigit */
>>
>> +#define _inline __inline /* circumvent header file issue */
>> +#include <wspiapi.h>
>> +
>>  #ifndef AI_ADDRCONFIG
>>  # define AI_ADDRCONFIG 0
>>  #endif
>> ***
>>
>> Signed-off-by: Robert Riebisch <rr@bttr-software.de>


-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.

Re: [Qemu-devel] QEMU SVN on Windows 2000 :-(

[Anthony Liguori]

Avi Kivity wrote:
> Anthony Liguori wrote:
>> Robert Riebisch wrote:
>>> Hi!
>>>
>>> Unfortunately Win32 binaries built from QEMU SVN don't run on Windows
>>> 2000 anymore, because of missing DLL entry points in `ws2_32.dll'.
>>>   
>>
>> Unfortunately, win2k is so old at this point, that I don't know that 
>> it's worth jumping through hoops to support.
>>
>> If someone can come up with a simple patch (with appropriately 
>> licensed code), then I'd be happy to apply it.  Otherwise, I don't 
>> think not supporting win2k as a host is a huge loss.
>>
>
> There is in fact a signed-off two-liner still in the thread:

"but it requires copyrighted file `Wspiapi.h' from MSVC2005, because 
MinGW doesn't provide such a file."

So if Wspiapi.h carries a GPL compatible license, it's fine to include.  
The patch lacks Wspiapi.h though so it'll break the build on mingw.

Regards,

Anthony Liguori

>>>
>>> --- qemu-sockets.c.orig    Wed Jan 14 19:34:22 2009
>>> +++ qemu-sockets.c    Mon Feb 02 22:04:42 2009
>>> @@ -22,6 +22,9 @@
>>>  #include "qemu_socket.h"
>>>  #include "qemu-common.h" /* for qemu_isdigit */
>>>
>>> +#define _inline __inline /* circumvent header file issue */
>>> +#include <wspiapi.h>
>>> +
>>>  #ifndef AI_ADDRCONFIG
>>>  # define AI_ADDRCONFIG 0
>>>  #endif
>>> ***
>>>
>>> Signed-off-by: Robert Riebisch <rr@bttr-software.de>
>
>

Re: [Qemu-devel] QEMU SVN on Windows 2000 :-(

[Daniel P. Berrange]

On Tue, Feb 03, 2009 at 06:31:16AM -0600, Anthony Liguori wrote:
> Avi Kivity wrote:
> >Anthony Liguori wrote:
> >>Robert Riebisch wrote:
> >>>Hi!
> >>>
> >>>Unfortunately Win32 binaries built from QEMU SVN don't run on Windows
> >>>2000 anymore, because of missing DLL entry points in `ws2_32.dll'.
> >>>  
> >>
> >>Unfortunately, win2k is so old at this point, that I don't know that 
> >>it's worth jumping through hoops to support.
> >>
> >>If someone can come up with a simple patch (with appropriately 
> >>licensed code), then I'd be happy to apply it.  Otherwise, I don't 
> >>think not supporting win2k as a host is a huge loss.
> >>
> >
> >There is in fact a signed-off two-liner still in the thread:
> 
> "but it requires copyrighted file `Wspiapi.h' from MSVC2005, because 
> MinGW doesn't provide such a file."
> 
> So if Wspiapi.h carries a GPL compatible license, it's fine to include.  
> The patch lacks Wspiapi.h though so it'll break the build on mingw.

Well MinGW already builds fine with getaddrinfo(), so no need for a GPL
header providing Wspiapi.h there. Since this is only needed for a few
Win builds, why not just make the include conditional on whether that 
header actually exists. eg

#ifdef HAVE_WSPIAPI_H
#include <Wspiapi.h>
#endif

Regards,
Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

Re: [Qemu-devel] QEMU SVN on Windows 2000 :-(

[Avi Kivity]

Anthony Liguori wrote:
>>
>> There is in fact a signed-off two-liner still in the thread:
>
> "but it requires copyrighted file `Wspiapi.h' from MSVC2005, because 
> MinGW doesn't provide such a file."
>
> So if Wspiapi.h carries a GPL compatible license, it's fine to 
> include.  The patch lacks Wspiapi.h though so it'll break the build on 
> mingw.

Sounds like a mingw bug, no?

-- 
error compiling committee.c: too many arguments to function

Re: [Qemu-devel] QEMU SVN on Windows 2000 :-(

[Anthony Liguori]

Daniel P. Berrange wrote:
> Well MinGW already builds fine with getaddrinfo(), so no need for a GPL
> header providing Wspiapi.h there. Since this is only needed for a few
> Win builds, why not just make the include conditional on whether that 
> header actually exists. eg
>
> #ifdef HAVE_WSPIAPI_H
> #include <Wspiapi.h>
> #endif
>   

If that works, that's fine.

Regards,

Anthony Liguori

> Regards,
> Daniel
>   

Re: [Qemu-devel] QEMU SVN on Windows 2000 :-(

[David Turner]

[-- Attachment #1: Type: text/plain, Size: 903 bytes --]

For the record, getaddrinfo() was introduced in Windows 2000 Professional
and Server, see end of
http://msdn.microsoft.com/en-us/library/ms738520(VS.85).aspx
(it's only missing from 2000 Workstation).

you just need to add -DWINVER=0x501 to your CFLAGS to be able to have it
properly declared (and linked to) with should be able to compile it with
mingw

hope this helps

On Tue, Feb 3, 2009 at 3:59 PM, Anthony Liguori <anthony@codemonkey.ws>wrote:

> Daniel P. Berrange wrote:
>
>> Well MinGW already builds fine with getaddrinfo(), so no need for a GPL
>> header providing Wspiapi.h there. Since this is only needed for a few
>> Win builds, why not just make the include conditional on whether that
>> header actually exists. eg
>>
>> #ifdef HAVE_WSPIAPI_H
>> #include <Wspiapi.h>
>> #endif
>>
>>
>
> If that works, that's fine.
>
> Regards,
>
> Anthony Liguori
>
>  Regards,
>> Daniel
>>
>>
>
>
>
>

[-- Attachment #2: Type: text/html, Size: 1657 bytes --]

Re: [Qemu-devel] QEMU SVN on Windows 2000 :-(

[Robert Riebisch]

David Turner wrote:

> For the record, getaddrinfo() was introduced in Windows 2000
> Professional and Server, see end of
> http://msdn.microsoft.com/en-us/library/ms738520(VS.85).aspx

I already wrote in my original post.

> (it's only missing from 2000 Workstation).

There's no such thing ("Workstation").

> you just need to add -DWINVER=0x501 to your CFLAGS to be able to have it

We already have "#define WINVER 0x0501" in `qemu_common.h".

> properly declared (and linked to) with should be able to compile it with
> mingw

But one would still need (copyrighted) `Wspiapi.h' to make the resulting
binary run on Windows 2000.

Robert Riebisch
-- 
BTTR Software
http://www.bttr-software.de/

Re: [Qemu-devel] QEMU SVN on Windows 2000 :-(

[Jamie Lokier]

Daniel P. Berrange wrote:
> > "but it requires copyrighted file `Wspiapi.h' from MSVC2005, because 
> > MinGW doesn't provide such a file."
> > 
> > So if Wspiapi.h carries a GPL compatible license, it's fine to include.  
> > The patch lacks Wspiapi.h though so it'll break the build on mingw.
> 
> Well MinGW already builds fine with getaddrinfo(), so no need for a GPL
> header providing Wspiapi.h there. Since this is only needed for a few
> Win builds, why not just make the include conditional on whether that 
> header actually exists. eg

It should compile, but the point is it will fail at run time on
most versions of Windows 2000, and all earlier Windows versions.

Imho it's standard practice on Windows to look up getaddrinfo()
dynamically, in case it doesn't exist - same for a few other
functions.  But maybe that's just my standard practice ;-)

Windows XP was introduced in 2003, iirc, about the same time as Linux
2.6.0, although major distributions didn't pick up Linux 2.6 until
years later.  Does Qemu run on Linux 2.4?

-- Jamie

Re: [Qemu-devel] QEMU SVN on Windows 2000 :-(

[Robert Reif]

Jamie Lokier wrote:
> years later.  Does Qemu run on Linux 2.4?
>
>   
QEMU runs on RedHat 9 which is 2.4.20 but only with this
patch (otherwise it just hangs at startup):

--- vl.c        (revision 6510)
+++ vl.c        (working copy)
@@ -1008,8 +1008,8 @@
 static struct qemu_alarm_timer alarm_timers[] = {
 #ifndef _WIN32
 #ifdef __linux__
-    {"dynticks", ALARM_FLAG_DYNTICKS, dynticks_start_timer,
-     dynticks_stop_timer, dynticks_rearm_timer, NULL},
+//    {"dynticks", ALARM_FLAG_DYNTICKS, dynticks_start_timer,
+//     dynticks_stop_timer, dynticks_rearm_timer, NULL},
     /* HPET - if available - is preferred */
     {"hpet", 0, hpet_start_timer, hpet_stop_timer, NULL, NULL},
     /* ...otherwise try RTC */

Re: [Qemu-devel] QEMU SVN on Windows 2000 :-(

[David Coppa]

dynticks was introduced in release 2.6.21.
Maybe a #ifdef around these lines is needed?

Best Regards
-david-

On Wed, Feb 4, 2009 at 4:21 PM, Robert Reif <reif@earthlink.net> wrote:
> Jamie Lokier wrote:
>>
>> years later.  Does Qemu run on Linux 2.4?
>>
>>
>
> QEMU runs on RedHat 9 which is 2.4.20 but only with this
> patch (otherwise it just hangs at startup):
>
> --- vl.c        (revision 6510)
> +++ vl.c        (working copy)
> @@ -1008,8 +1008,8 @@
> static struct qemu_alarm_timer alarm_timers[] = {
> #ifndef _WIN32
> #ifdef __linux__
> -    {"dynticks", ALARM_FLAG_DYNTICKS, dynticks_start_timer,
> -     dynticks_stop_timer, dynticks_rearm_timer, NULL},
> +//    {"dynticks", ALARM_FLAG_DYNTICKS, dynticks_start_timer,
> +//     dynticks_stop_timer, dynticks_rearm_timer, NULL},
>    /* HPET - if available - is preferred */
>    {"hpet", 0, hpet_start_timer, hpet_stop_timer, NULL, NULL},
>    /* ...otherwise try RTC */
>
>
>

Re: [Qemu-devel] QEMU SVN on Windows 2000 :-(

[Paul Brook]

On Wednesday 04 February 2009, David Coppa wrote:
> dynticks was introduced in release 2.6.21.

You're thinking of something completely different.

Paul

Re: [Qemu-devel] QEMU SVN on Windows 2000 :-(

[Jamie Lokier]

Robert Reif wrote:
> Jamie Lokier wrote:
> >years later.  Does Qemu run on Linux 2.4?
> QEMU runs on RedHat 9 which is 2.4.20 but only with this
> patch (otherwise it just hangs at startup):

That suggests a latent bug in QEMU - there's no obvious reason why
dynticks wouldn't work on Linux 2.4.20.

-- Jamie

Re: [Qemu-devel] QEMU SVN on Windows 2000 :-(

[Luca Tettamanti]

On Wed, Feb 4, 2009 at 4:21 PM, Robert Reif <reif@earthlink.net> wrote:
> Jamie Lokier wrote:
>>
>> years later.  Does Qemu run on Linux 2.4?
>
> QEMU runs on RedHat 9 which is 2.4.20 but only with this
> patch (otherwise it just hangs at startup):
>
> --- vl.c        (revision 6510)
> +++ vl.c        (working copy)
> @@ -1008,8 +1008,8 @@
> static struct qemu_alarm_timer alarm_timers[] = {
> #ifndef _WIN32
> #ifdef __linux__
> -    {"dynticks", ALARM_FLAG_DYNTICKS, dynticks_start_timer,
> -     dynticks_stop_timer, dynticks_rearm_timer, NULL},
> +//    {"dynticks", ALARM_FLAG_DYNTICKS, dynticks_start_timer,
> +//     dynticks_stop_timer, dynticks_rearm_timer, NULL},
>    /* HPET - if available - is preferred */
>    {"hpet", 0, hpet_start_timer, hpet_stop_timer, NULL, NULL},
>    /* ...otherwise try RTC */

You can override the order of the timers with -clock, e.g.:
-clock hpet,rtc,unix
will try first hpet, then rtc and unix (ignoring dynticks).
It should hang though, can you see if dynticks_rearm_timer gets called?

Luca

Re: [Qemu-devel] QEMU SVN on Windows 2000 :-(

[David Turner]

[-- Attachment #1: Type: text/plain, Size: 790 bytes --]

On Tue, Feb 3, 2009 at 10:27 PM, Robert Riebisch <rr@bttr-software.de>wrote:

>
> > (it's only missing from 2000 Workstation).
>
> There's no such thing ("Workstation").
>

Damn, damn, you're absolutely right... oh my memory :-)


> > properly declared (and linked to) with should be able to compile it with
> > mingw
>
> But one would still need (copyrighted) `Wspiapi.h' to make the resulting
> binary run on Windows 2000.
>

I'm curious to know that this header contains that makes the result
magically run on Windows 2000.
In the meantime, I'll probably change my code to use GetProcAddress() to
load it dynamically it
available and revert to gethostbyname() when applicable.

thanks for the clarification


>
> Robert Riebisch
> --
> BTTR Software
> http://www.bttr-software.de/
>
>
>

[-- Attachment #2: Type: text/html, Size: 1709 bytes --]