From: Anthony Liguori <aliguori@us.ibm.com>
To: Glauber Costa <glommer@gmail.com>
Cc: Glauber Costa <glommer@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] don't expose lm bit if kernel is not 64-bit capable.
Date: Tue, 03 Feb 2009 11:58:49 -0600 [thread overview]
Message-ID: <498885D9.7050104@us.ibm.com> (raw)
In-Reply-To: <5d6222a80902030752h3841fdbdsff9a78f88d53a579@mail.gmail.com>
Glauber Costa wrote:
> On Tue, Feb 3, 2009 at 1:44 PM, Alexander Graf <agraf@suse.de> wrote:
>
>> This doesn't really compile on win32, does it?
>>
> This is kvm code, and as we don't have kvm for win32 hosts, possibly
> does not matter.
>
Would be better to use a kvm accessor to wrap this functionality.
kvm_is_lmkernel() or something. Makes things more obviously portable on
another platform.
Regards,
Anthony Liguori
>> Why not check for sizeof(long) == 4? That way you'd know that you're running
>> 32-bit code which can only handle 32-bit guests anyway, right? And if you're
>> running 64-bit userspace code, you know that the kernel is 64-bit aware.
>>
>
> How about qemu/kvm compiled in a 32-bit environment, thus, sizeof long == 4,
> running in a x86_64 capable kernel?
>
>
next prev parent reply other threads:[~2009-02-03 17:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-03 15:04 [Qemu-devel] [PATCH] don't expose lm bit if kernel is not 64-bit capable Glauber Costa
2009-02-03 15:44 ` Alexander Graf
2009-02-03 15:52 ` Glauber Costa
2009-02-03 17:58 ` Anthony Liguori [this message]
2009-02-03 19:35 ` Avi Kivity
2009-02-03 19:37 ` Avi Kivity
2009-02-03 20:00 ` Glauber Costa
2009-02-03 21:14 ` Anthony Liguori
2009-02-03 21:35 ` Glauber Costa
2009-02-03 21:42 ` Anthony Liguori
2009-02-04 8:10 ` Avi Kivity
2009-02-03 19:37 ` Avi Kivity
-- strict thread matches above, loose matches on Subject: below --
2009-02-03 20:15 Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=498885D9.7050104@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=glommer@gmail.com \
--cc=glommer@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).