From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LUPYG-00052V-VI
	for qemu-devel@nongnu.org; Tue, 03 Feb 2009 12:59:12 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LUPYF-00051d-AL
	for qemu-devel@nongnu.org; Tue, 03 Feb 2009 12:59:12 -0500
Received: from [199.232.76.173] (port=49673 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LUPYE-00051S-W8
	for qemu-devel@nongnu.org; Tue, 03 Feb 2009 12:59:11 -0500
Received: from e6.ny.us.ibm.com ([32.97.182.146]:59981)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <aliguori@us.ibm.com>) id 1LUPYE-0008MK-LH
	for qemu-devel@nongnu.org; Tue, 03 Feb 2009 12:59:10 -0500
Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234])
	by e6.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n13HxcAJ029980
	for <qemu-devel@nongnu.org>; Tue, 3 Feb 2009 12:59:38 -0500
Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64])
	by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id
	n13Hx67P159126
	for <qemu-devel@nongnu.org>; Tue, 3 Feb 2009 12:59:06 -0500
Received: from d01av04.pok.ibm.com (loopback [127.0.0.1])
	by d01av04.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
	n13Hx6L3018357
	for <qemu-devel@nongnu.org>; Tue, 3 Feb 2009 12:59:06 -0500
Message-ID: <498885D9.7050104@us.ibm.com>
Date: Tue, 03 Feb 2009 11:58:49 -0600
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] don't expose lm bit if kernel is not 64-bit
	capable.
References: <1233673454-14526-1-git-send-email-glommer@redhat.com>
	<0787F5E2-2C38-43C2-A9CB-97BA8A36F212@suse.de>
	<5d6222a80902030752h3841fdbdsff9a78f88d53a579@mail.gmail.com>
In-Reply-To: <5d6222a80902030752h3841fdbdsff9a78f88d53a579@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Glauber Costa <glommer@gmail.com>
Cc: Glauber Costa <glommer@redhat.com>, qemu-devel@nongnu.org

Glauber Costa wrote:
> On Tue, Feb 3, 2009 at 1:44 PM, Alexander Graf <agraf@suse.de> wrote:
>   
>> This doesn't really compile on win32, does it?
>>     
> This is kvm code, and as we don't have kvm for win32 hosts, possibly
> does not matter.
>   

Would be better to use a kvm accessor to wrap this functionality.  
kvm_is_lmkernel() or something.  Makes things more obviously portable on 
another platform.

Regards,

Anthony Liguori

>> Why not check for sizeof(long) == 4? That way you'd know that you're running
>> 32-bit code which can only handle 32-bit guests anyway, right? And if you're
>> running 64-bit userspace code, you know that the kernel is 64-bit aware.
>>     
>
> How about qemu/kvm compiled in a 32-bit environment, thus, sizeof long == 4,
> running in a x86_64 capable kernel?
>
>