From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LUSbF-0004zI-Ni
	for qemu-devel@nongnu.org; Tue, 03 Feb 2009 16:14:29 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LUSbD-0004yS-4u
	for qemu-devel@nongnu.org; Tue, 03 Feb 2009 16:14:29 -0500
Received: from [199.232.76.173] (port=52611 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LUSbD-0004yO-0L
	for qemu-devel@nongnu.org; Tue, 03 Feb 2009 16:14:27 -0500
Received: from e6.ny.us.ibm.com ([32.97.182.146]:43334)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <aliguori@us.ibm.com>) id 1LUSbC-0007Ff-Ol
	for qemu-devel@nongnu.org; Tue, 03 Feb 2009 16:14:26 -0500
Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236])
	by e6.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n13LErpC004773
	for <qemu-devel@nongnu.org>; Tue, 3 Feb 2009 16:14:53 -0500
Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217])
	by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id
	n13LELY6182640
	for <qemu-devel@nongnu.org>; Tue, 3 Feb 2009 16:14:21 -0500
Received: from d01av03.pok.ibm.com (loopback [127.0.0.1])
	by d01av03.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
	n13LELbN025931
	for <qemu-devel@nongnu.org>; Tue, 3 Feb 2009 16:14:21 -0500
Message-ID: <4988B39B.5050509@us.ibm.com>
Date: Tue, 03 Feb 2009 15:14:03 -0600
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] don't expose lm bit if kernel is not 64-bit
	capable.
References: <1233673454-14526-1-git-send-email-glommer@redhat.com>
	<49889CEB.7060602@redhat.com>
	<5d6222a80902031200i5b46b536vd2a95089d48a098e@mail.gmail.com>
In-Reply-To: <5d6222a80902031200i5b46b536vd2a95089d48a098e@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Glauber Costa <glommer@gmail.com>
Cc: qemu-devel@nongnu.org

Glauber Costa wrote:
>> It would be better to use KVM_GET_SUPPORTED_CPUID for this (and similar).
>>  uname() can lie, and in theory kvm can support x86_64 on i386 kernels
>> (although patches to implement this would be rejected on cost/benefit and
>> aesthetic concerns).
>>     
>
> I sent a patch that implements this last week, but anthony seemed to
> be more inclined
> towards this approach.
>   

All I said was that if we used KVM_GET_SUPPORTED_CPUID, we had to do 
something about save/restore since it can mask arbitrary things.

Regards,

Anthony Liguori