From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LUcpQ-0007tN-FX
	for qemu-devel@nongnu.org; Wed, 04 Feb 2009 03:09:48 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LUcpO-0007tB-3X
	for qemu-devel@nongnu.org; Wed, 04 Feb 2009 03:09:47 -0500
Received: from [199.232.76.173] (port=51663 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LUcpN-0007t8-UA
	for qemu-devel@nongnu.org; Wed, 04 Feb 2009 03:09:45 -0500
Received: from mx20.gnu.org ([199.232.41.8]:39301)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <avi@redhat.com>) id 1LUcpN-0002u2-G0
	for qemu-devel@nongnu.org; Wed, 04 Feb 2009 03:09:45 -0500
Received: from mx2.redhat.com ([66.187.237.31])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1LUcpM-0007o9-Gw
	for qemu-devel@nongnu.org; Wed, 04 Feb 2009 03:09:44 -0500
Message-ID: <49894D5A.7000209@redhat.com>
Date: Wed, 04 Feb 2009 10:10:02 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] don't expose lm bit if kernel is not 64-bit
	capable.
References: <1233673454-14526-1-git-send-email-glommer@redhat.com>	<49889CEB.7060602@redhat.com>	<5d6222a80902031200i5b46b536vd2a95089d48a098e@mail.gmail.com>
	<4988B39B.5050509@us.ibm.com>
In-Reply-To: <4988B39B.5050509@us.ibm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Glauber Costa <glommer@gmail.com>

Anthony Liguori wrote: 
>
> All I said was that if we used KVM_GET_SUPPORTED_CPUID, we had to do 
> something about save/restore since it can mask arbitrary things.
>

Right, we need to transfer the cpuid bits to the migration target.

btw, we need to read them out of the kernel, since the cpuid instruction 
accesses hidden processor state (the results of cpuid don't depend 
simply on input eax and ecx).

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.