From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LUfni-0001UI-G7
	for qemu-devel@nongnu.org; Wed, 04 Feb 2009 06:20:14 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LUfnh-0001U4-Ug
	for qemu-devel@nongnu.org; Wed, 04 Feb 2009 06:20:14 -0500
Received: from [199.232.76.173] (port=59781 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LUfnh-0001Tx-O5
	for qemu-devel@nongnu.org; Wed, 04 Feb 2009 06:20:13 -0500
Received: from smtp.ctxuk.citrix.com ([62.200.22.115]:55915
	helo=SMTP.EU.CITRIX.COM)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <Stefano.Stabellini@eu.citrix.com>)
	id 1LUfnh-0001jZ-FP
	for qemu-devel@nongnu.org; Wed, 04 Feb 2009 06:20:13 -0500
Message-ID: <49897937.8000203@eu.citrix.com>
Date: Wed, 04 Feb 2009 11:17:11 +0000
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: more about serial ports: do they even work?
References: <497E1B15.2090908@msgid.tls.msk.ru>	<497E1F7D.90300@msgid.tls.msk.ru>
	<49876547.1080904@cisco.com>	<49876678.4090808@msgid.tls.msk.ru>
	<4987674E.9050201@cisco.com> <4987FCBA.7020104@msgid.tls.msk.ru>
In-Reply-To: <4987FCBA.7020104@msgid.tls.msk.ru>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: KVM list <kvm@vger.kernel.org>, "David S. Ahern" <daahern@cisco.com>

Michael Tokarev wrote:

> David S. Ahern wrote:
>> Michael Tokarev wrote:
>>> David S. Ahern wrote:
>>>>      case CHR_IOCTL_SERIAL_SET_TIOCM:
>>>>          {
>>>>              int sarg = *(int *)arg;
>>>>              int targ = 0;
>>>> +            ioctl(s->fd_in, TIOCMGET, &targ);
>>> here, one more operation is necessary:
>>>                targ &= ~(TIOCM_DTR|TIOCM_RTS);
>> Interesting. that change was not needed to fix my problem.
> 
> It just means you (or, rather, your guests) never really needed to
> DROP those signal lines, only to raise them.
> 
>>>>              if (sarg | CHR_TIOCM_DTR)
>>>>                  targ |= TIOCM_DTR;
>>>>              if (sarg | CHR_TIOCM_RTS)
>>>>                  targ |= TIOCM_RTS;
> 
> Without that line above, the code never drops the two bits, once
> set they can't be "removed" anymore.
> 
> By the way, this is upstream qemu issue, not kvm one, and has to be
> pushed as such.  Good you CC'd qemu list.
> 


Either the two lines above or we could parse the whole set of possible
flags, like we do in the CHR_IOCTL_SERIAL_GET_TIOCM case.