From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LUhCx-0001Kl-Ax
	for qemu-devel@nongnu.org; Wed, 04 Feb 2009 07:50:23 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LUhCu-0001KJ-LQ
	for qemu-devel@nongnu.org; Wed, 04 Feb 2009 07:50:22 -0500
Received: from [199.232.76.173] (port=42869 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LUhCu-0001KE-J9
	for qemu-devel@nongnu.org; Wed, 04 Feb 2009 07:50:20 -0500
Received: from moutng.kundenserver.de ([212.227.17.8]:55589)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <weil@mail.berlios.de>) id 1LUhCt-0001hK-Qb
	for qemu-devel@nongnu.org; Wed, 04 Feb 2009 07:50:20 -0500
Received: from localhost ([127.0.0.1] ident=stefan)
	by flocke.weilnetz.de with esmtp (Exim 4.69)
	(envelope-from <weil@mail.berlios.de>) id 1LUhCq-0002Io-E4
	for qemu-devel@nongnu.org; Wed, 04 Feb 2009 13:50:17 +0100
Message-ID: <49898F07.3070203@mail.berlios.de>
Date: Wed, 04 Feb 2009 13:50:15 +0100
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Add single stepping option for all targets
References: <494D18B1.8080900@mail.berlios.de>	<4985FD31.4010000@mail.berlios.de>
	<761ea48b0902011424s6bebea3dj7cc7e6c106b6adca@mail.gmail.com>
In-Reply-To: <761ea48b0902011424s6bebea3dj7cc7e6c106b6adca@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Laurent Desnogues schrieb:
> I have two comments:
>    - as Stuart previously wrote, user mode would be useful to
>      have
>   

Right. A quick-and-dirty solution to set the flag for user mode is very
simple
but also dirty: Today, bsd-user, darwin-user and linux-user would need the
same kind of patch in main.c. There is already too much code duplication
(or triplication) in these three directories, so a common code basis for all
user modes would help. I suggest to take the current patch first, then clean
the user mode code in a second step, then add single stepping for
user mode in a third step.

>    - shouldn't you also prevent block chaining from being done
>      for this feature to be really useful?
>   

The current implementation replaces conditional compilations
for several system emulations and adds the same feature to those
system emulations which did not have a conditional compilation.

I (and other users, especially those who added the conditional
compilation) use this feature, so it is really useful.

Maybe it can be improved the way you suggested. Do you have code
for this?

>
> Laurent
>
>
>
>   

Regards
Stefan