From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LUtUU-0006n9-GE for qemu-devel@nongnu.org; Wed, 04 Feb 2009 20:57:18 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LUtUT-0006mx-UN for qemu-devel@nongnu.org; Wed, 04 Feb 2009 20:57:18 -0500 Received: from [199.232.76.173] (port=36356 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LUtUT-0006mu-Nh for qemu-devel@nongnu.org; Wed, 04 Feb 2009 20:57:17 -0500 Received: from e34.co.us.ibm.com ([32.97.110.152]:37781) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LUtUT-0002NE-A4 for qemu-devel@nongnu.org; Wed, 04 Feb 2009 20:57:17 -0500 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e34.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id n151tha5014840 for ; Wed, 4 Feb 2009 18:55:43 -0700 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id n151vCSd203736 for ; Wed, 4 Feb 2009 18:57:12 -0700 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n151vBJF008935 for ; Wed, 4 Feb 2009 18:57:11 -0700 Message-ID: <498A4766.6050905@us.ibm.com> Date: Wed, 04 Feb 2009 19:56:54 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH 1/4] Add a scatter-gather list type and accessors References: <4989EC29.9050705@us.ibm.com> <4989FACD.6090309@redhat.com> <4989FC3B.7010407@us.ibm.com> <20090204.172959.-1041657313.imp@bsdimp.com> In-Reply-To: <20090204.172959.-1041657313.imp@bsdimp.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "M. Warner Losh" Cc: qemu-devel@nongnu.org, avi@redhat.com M. Warner Losh wrote: > In message: <4989FC3B.7010407@us.ibm.com> > Anthony Liguori writes: > : Avi Kivity wrote: > : > Anthony Liguori wrote: > : >> Avi Kivity wrote: > : >>> Scatter-gather lists are used extensively in dma-capable devices; a > : >>> single data structure allows more code reuse later on. > : >>> > : >>> diff --git a/dma-helpers.c b/dma-helpers.c > : >>> new file mode 100644 > : >>> index 0000000..315834e > : >>> --- /dev/null > : >>> +++ b/dma-helpers.c > : >>> @@ -0,0 +1,29 @@ > : >>> > : >> > : >> Needs copyright/license. > : > > : > Sure. > : > > : > Is it possible to have a blanket license for files which don't have > : > explicit terms? I don't much like boilerplate. > : > : I'd greatly prefer not to. You can refer to a COPYING and we can have a > : default COPYING file but a copyright is really needed as far as I > : understand it. > > The copyright exists regardless of any notices being on the file. In > the absence of a license to copy, however, the default legally defined > license is 'you may not copy it at all'. Based on this, you need to > have an explicit license for all files. However, it only needs to be > clear what the license for a given file is. You don't have to have > the license in each and every file. > To put it quite simply, I can't take a patch that introduces a new file without a copyright/license in the header. So there's no need to discuss it further than that :-) Regards, Anthony Liguori > Warner >