qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <aliguori@us.ibm.com>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 0/6] Unify memory allocation failure handling
Date: Thu, 05 Feb 2009 16:07:56 -0600	[thread overview]
Message-ID: <498B633C.1010105@us.ibm.com> (raw)
In-Reply-To: <1233832126-9046-1-git-send-email-avi@redhat.com>

Avi Kivity wrote:
> Memory allocation failures are a very rare condition on virtual-memory
> hosts.  They are also very difficult to handle correctly (especially in a
> hardware emulation context).  Because of this, it is better to gracefully
> terminate emulation rather than executing untested or even unwritten recovery
> code paths.
>
> This patchset modifies qemu_malloc() and related functions to terminate
> on error, and updates callers not to perform their own error handling.  In
> many cases error handling was already missing or incorrect.
>
> Avi Kivity (6):
>   Terminate emulation on memory allocation failure
>   block: remove error handling from qemu_malloc() callers
>   audio: remove error handling from qemu_malloc() callers
>   hw: remove error handling from qemu_malloc() callers
>   targets: remove error handling from qemu_malloc() callers
>   toplevel: remove error handling from qemu_malloc() callers
>   

Applied all.  Thanks.

Did you do this all by hand or were scripts involved?

Regards,

Anthony Liguori

  parent reply	other threads:[~2009-02-05 22:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-05 11:08 [Qemu-devel] [PATCH 0/6] Unify memory allocation failure handling Avi Kivity
2009-02-05 11:08 ` [Qemu-devel] [PATCH 1/6] Terminate emulation on memory allocation failure Avi Kivity
2009-02-05 12:01   ` Daniel P. Berrange
2009-02-05 12:22     ` Avi Kivity
2009-02-05 17:43       ` Ian Jackson
2009-02-05 11:08 ` [Qemu-devel] [PATCH 2/6] block: remove error handling from qemu_malloc() callers Avi Kivity
2009-02-05 11:08 ` [Qemu-devel] [PATCH 3/6] audio: " Avi Kivity
2009-02-05 11:08 ` [Qemu-devel] [PATCH 4/6] hw: " Avi Kivity
2009-02-05 11:08 ` [Qemu-devel] [PATCH 5/6] targets: " Avi Kivity
2009-02-05 11:08 ` [Qemu-devel] [PATCH 6/6] toplevel: " Avi Kivity
2009-02-05 17:43 ` [Qemu-devel] [PATCH 0/6] Unify memory allocation failure handling Ian Jackson
2009-02-05 22:07 ` Anthony Liguori [this message]
2009-02-06  8:47   ` [Qemu-devel] " Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=498B633C.1010105@us.ibm.com \
    --to=aliguori@us.ibm.com \
    --cc=avi@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).