From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LVCOS-0006uF-6h for qemu-devel@nongnu.org; Thu, 05 Feb 2009 17:08:20 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LVCOQ-0006tX-Ik for qemu-devel@nongnu.org; Thu, 05 Feb 2009 17:08:19 -0500 Received: from [199.232.76.173] (port=44965 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LVCOQ-0006tP-CD for qemu-devel@nongnu.org; Thu, 05 Feb 2009 17:08:18 -0500 Received: from e4.ny.us.ibm.com ([32.97.182.144]:38660) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LVCOP-0002gQ-NA for qemu-devel@nongnu.org; Thu, 05 Feb 2009 17:08:18 -0500 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e4.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n15M6JBu029186 for ; Thu, 5 Feb 2009 17:06:19 -0500 Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id n15M8Fsi162316 for ; Thu, 5 Feb 2009 17:08:15 -0500 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n15M8FdH007271 for ; Thu, 5 Feb 2009 17:08:15 -0500 Message-ID: <498B633C.1010105@us.ibm.com> Date: Thu, 05 Feb 2009 16:07:56 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1233832126-9046-1-git-send-email-avi@redhat.com> In-Reply-To: <1233832126-9046-1-git-send-email-avi@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 0/6] Unify memory allocation failure handling Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: qemu-devel@nongnu.org Avi Kivity wrote: > Memory allocation failures are a very rare condition on virtual-memory > hosts. They are also very difficult to handle correctly (especially in a > hardware emulation context). Because of this, it is better to gracefully > terminate emulation rather than executing untested or even unwritten recovery > code paths. > > This patchset modifies qemu_malloc() and related functions to terminate > on error, and updates callers not to perform their own error handling. In > many cases error handling was already missing or incorrect. > > Avi Kivity (6): > Terminate emulation on memory allocation failure > block: remove error handling from qemu_malloc() callers > audio: remove error handling from qemu_malloc() callers > hw: remove error handling from qemu_malloc() callers > targets: remove error handling from qemu_malloc() callers > toplevel: remove error handling from qemu_malloc() callers > Applied all. Thanks. Did you do this all by hand or were scripts involved? Regards, Anthony Liguori