From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LVaMG-0006RN-7a for qemu-devel@nongnu.org; Fri, 06 Feb 2009 18:43:40 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LVaME-0006R5-Ll for qemu-devel@nongnu.org; Fri, 06 Feb 2009 18:43:39 -0500 Received: from [199.232.76.173] (port=33950 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LVaME-0006R2-GB for qemu-devel@nongnu.org; Fri, 06 Feb 2009 18:43:38 -0500 Received: from yw-out-1718.google.com ([74.125.46.155]:1132) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LVaMD-0006I8-Ua for qemu-devel@nongnu.org; Fri, 06 Feb 2009 18:43:38 -0500 Received: by yw-out-1718.google.com with SMTP id 6so110660ywa.82 for ; Fri, 06 Feb 2009 15:43:37 -0800 (PST) Message-ID: <498CCB11.1090005@codemonkey.ws> Date: Fri, 06 Feb 2009 17:43:13 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 0/9] encryption code changes References: <1233954540-4754-1-git-send-email-ehabkost@redhat.com> In-Reply-To: <1233954540-4754-1-git-send-email-ehabkost@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Eduardo Habkost wrote: > Hi, > > This patch series for qemu contain multiple changes on the way encryption > and authentication code is handled. > > The first patch is a behaviour change to avoid silent security holes on > the VNC server caused by user configuration errors. > > Patches 2 and 3 are bugfixes to some of the multiple problems > I had with monitor_readline(), when testing the qcow encryption > support. monitor_readline() is still not completely functional, but > at least it allows the qcow password to be read when an qcow encrypted > image is specified on the command-line, now. > > The remaining patches may be more controversial. The first half makes the > use of aes.c and d3des.c optional at compile time. The rest remove aes.c > and d3des.c from the source tree and replace them with calls to libgcrypt. > What's the availability of libgcrypt? Are there Windows versions readily available? That would be my biggest concern here. Regards, Anthony Liguori