From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LVaTt-0001UY-UJ
	for qemu-devel@nongnu.org; Fri, 06 Feb 2009 18:51:34 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LVaTs-0001TE-AZ
	for qemu-devel@nongnu.org; Fri, 06 Feb 2009 18:51:33 -0500
Received: from [199.232.76.173] (port=40326 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LVaTs-0001T3-1K
	for qemu-devel@nongnu.org; Fri, 06 Feb 2009 18:51:32 -0500
Received: from rn-out-0910.google.com ([64.233.170.187]:11460)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1LVaTr-0007OS-Lm
	for qemu-devel@nongnu.org; Fri, 06 Feb 2009 18:51:31 -0500
Received: by rn-out-0910.google.com with SMTP id j36so784991rne.8
	for <qemu-devel@nongnu.org>; Fri, 06 Feb 2009 15:51:31 -0800 (PST)
Message-ID: <498CCCEC.4050205@codemonkey.ws>
Date: Fri, 06 Feb 2009 17:51:08 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [RFC][PATCH] disable special ioapic inti0 routing
References: <498CC81B.2070407@web.de>
In-Reply-To: <498CC81B.2070407@web.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>, Beth Kon <eak@us.ibm.com>, Avi Kivity <avi@redhat.com>

Jan Kiszka wrote:
> This patch comes from the kvm tree and fixes the timer IRQ routing for
> me which is broken from the POV of certain Linux guest kernels. As I'm
> not up-to-date with the development around that problematic hunk, I'm
> leaving it to someone more deeply involved to sign this off. But please
> commit some fix.
>   

Are you using an old bios by chance?  The reason this fixes KVM has 
nothing to do with QEMU FWIW so if this fixes something for you, it's 
just a coincidence.

Regards,

Anthony Liguroi

> Thanks,
> Jan
>
> ------->
>
> From: Avi Kivity <avi@redhat.com>
>
> we don't support it yet (need bios support, and modifications to kernel
> irq routing).
>
> ---
>  qemu/hw/apic.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/qemu/hw/apic.c b/qemu/hw/apic.c
> index df80444..f9ef995 100644
> --- a/qemu/hw/apic.c
> +++ b/qemu/hw/apic.c
> @@ -1055,12 +1055,14 @@ void ioapic_set_irq(void *opaque, int vector, int level)
>  {
>      IOAPICState *s = opaque;
>  
> +#if 0
>      /* ISA IRQs map to GSI 1-1 except for IRQ0 which maps
>       * to GSI 2.  GSI maps to ioapic 1-1.  This is not
>       * the cleanest way of doing it but it should work. */
>  
>      if (vector == 0)
>          vector = 2;
> +#endif
>  
>      if (vector >= 0 && vector < IOAPIC_NUM_PINS) {
>          uint32_t mask = 1 << vector;
>
>
>
>