From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LVc1z-0008M9-4f
	for qemu-devel@nongnu.org; Fri, 06 Feb 2009 20:30:51 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LVc1x-0008Lw-4b
	for qemu-devel@nongnu.org; Fri, 06 Feb 2009 20:30:49 -0500
Received: from [199.232.76.173] (port=40530 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LVc1w-0008Lt-UH
	for qemu-devel@nongnu.org; Fri, 06 Feb 2009 20:30:48 -0500
Received: from yx-out-1718.google.com ([74.125.44.153]:41325)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1LVc1w-00072A-DD
	for qemu-devel@nongnu.org; Fri, 06 Feb 2009 20:30:48 -0500
Received: by yx-out-1718.google.com with SMTP id 3so498473yxi.82
	for <qemu-devel@nongnu.org>; Fri, 06 Feb 2009 17:30:47 -0800 (PST)
Message-ID: <498CE430.8010708@codemonkey.ws>
Date: Fri, 06 Feb 2009 19:30:24 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <498CC81B.2070407@web.de> <498CCCEC.4050205@codemonkey.ws>
	<498CD0AF.9040906@web.de>
In-Reply-To: <498CD0AF.9040906@web.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [RFC][PATCH] disable special ioapic inti0 routing
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Beth Kon <eak@us.ibm.com>, qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>

Jan Kiszka wrote:
> Anthony Liguori wrote:
>   
>> Jan Kiszka wrote:
>>     
>>> This patch comes from the kvm tree and fixes the timer IRQ routing for
>>> me which is broken from the POV of certain Linux guest kernels. As I'm
>>> not up-to-date with the development around that problematic hunk, I'm
>>> leaving it to someone more deeply involved to sign this off. But please
>>> commit some fix.
>>>   
>>>       
>> Are you using an old bios by chance?  The reason this fixes KVM has
>> nothing to do with QEMU FWIW so if this fixes something for you, it's
>> just a coincidence.
>>     
>
> My first thought as well, but the binary bios from latest svn made no
> difference.
>   

What linux guests broke?

Regards,

Anthony Liguori

> Jan
>
>   
>> Regards,
>>
>> Anthony Liguroi
>>
>>     
>>> Thanks,
>>> Jan
>>>
>>> ------->
>>>
>>> From: Avi Kivity <avi@redhat.com>
>>>
>>> we don't support it yet (need bios support, and modifications to kernel
>>> irq routing).
>>>
>>> ---
>>>  qemu/hw/apic.c |    2 ++
>>>  1 files changed, 2 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/qemu/hw/apic.c b/qemu/hw/apic.c
>>> index df80444..f9ef995 100644
>>> --- a/qemu/hw/apic.c
>>> +++ b/qemu/hw/apic.c
>>> @@ -1055,12 +1055,14 @@ void ioapic_set_irq(void *opaque, int vector,
>>> int level)
>>>  {
>>>      IOAPICState *s = opaque;
>>>  
>>> +#if 0
>>>      /* ISA IRQs map to GSI 1-1 except for IRQ0 which maps
>>>       * to GSI 2.  GSI maps to ioapic 1-1.  This is not
>>>       * the cleanest way of doing it but it should work. */
>>>  
>>>      if (vector == 0)
>>>          vector = 2;
>>> +#endif
>>>  
>>>      if (vector >= 0 && vector < IOAPIC_NUM_PINS) {
>>>          uint32_t mask = 1 << vector;
>>>
>>>
>>>
>>>   
>>>       
>>
>>
>>     
>
>
>