From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LWXOq-0003zV-Pm for qemu-devel@nongnu.org; Mon, 09 Feb 2009 09:46:16 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LWXOo-0003yP-Hm for qemu-devel@nongnu.org; Mon, 09 Feb 2009 09:46:15 -0500 Received: from [199.232.76.173] (port=53049 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LWXOn-0003yC-68 for qemu-devel@nongnu.org; Mon, 09 Feb 2009 09:46:13 -0500 Received: from e2.ny.us.ibm.com ([32.97.182.142]:54759) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LWXOm-000699-S2 for qemu-devel@nongnu.org; Mon, 09 Feb 2009 09:46:12 -0500 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by e2.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n19EiDqV032199 for ; Mon, 9 Feb 2009 09:44:13 -0500 Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id n19EkA9G179612 for ; Mon, 9 Feb 2009 09:46:10 -0500 Received: from d01av03.pok.ibm.com (loopback [127.0.0.1]) by d01av03.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n19EkALf024162 for ; Mon, 9 Feb 2009 09:46:10 -0500 Received: from squirrel.codemonkey.ws (sig-9-65-207-138.mts.ibm.com [9.65.207.138]) by d01av03.pok.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id n19Ek8IP024076 for ; Mon, 9 Feb 2009 09:46:09 -0500 Message-ID: <4990419B.7060908@us.ibm.com> Date: Mon, 09 Feb 2009 08:45:47 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 02/17] block: Improve bdrv_iterate References: <20090207181627.13667.9979.stgit@mchn012c.ww002.siemens.net> <20090207181627.13667.72268.stgit@mchn012c.ww002.siemens.net> In-Reply-To: <20090207181627.13667.72268.stgit@mchn012c.ww002.siemens.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Jan Kiszka wrote: > Make bdrv_iterate more useful by passing the BlockDriverState to the > iterator instead of the device name. > > Signed-off-by: Jan Kiszka > > --- > > block.c | 4 ++-- > block.h | 3 ++- > monitor.c | 3 ++- > $ grep -l bdrv_iterate *.c hw/*.c block.c monitor.c qemu-img.c vl.c So this patch will break the build. Regards, Anthony Liguori