From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LWXQ2-0004ln-P9
	for qemu-devel@nongnu.org; Mon, 09 Feb 2009 09:47:30 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LWXQ0-0004kT-2D
	for qemu-devel@nongnu.org; Mon, 09 Feb 2009 09:47:30 -0500
Received: from [199.232.76.173] (port=53069 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LWXPz-0004kJ-QN
	for qemu-devel@nongnu.org; Mon, 09 Feb 2009 09:47:27 -0500
Received: from e5.ny.us.ibm.com ([32.97.182.145]:41238)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <aliguori@us.ibm.com>) id 1LWXPz-0006JK-A4
	for qemu-devel@nongnu.org; Mon, 09 Feb 2009 09:47:27 -0500
Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234])
	by e5.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n19Ej24K006277
	for <qemu-devel@nongnu.org>; Mon, 9 Feb 2009 09:45:02 -0500
Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216])
	by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id
	n19ElQBO186782
	for <qemu-devel@nongnu.org>; Mon, 9 Feb 2009 09:47:26 -0500
Received: from d01av02.pok.ibm.com (loopback [127.0.0.1])
	by d01av02.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
	n19EkLVk017741
	for <qemu-devel@nongnu.org>; Mon, 9 Feb 2009 09:46:21 -0500
Received: from squirrel.codemonkey.ws (sig-9-65-207-138.mts.ibm.com
	[9.65.207.138])
	by d01av02.pok.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id
	n19EkK1V017648
	for <qemu-devel@nongnu.org>; Mon, 9 Feb 2009 09:46:21 -0500
Message-ID: <499041E7.4070005@us.ibm.com>
Date: Mon, 09 Feb 2009 08:47:03 -0600
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 04/17] monitor: Report encrypted disks in
	snapshot mode
References: <20090207181627.13667.9979.stgit@mchn012c.ww002.siemens.net>
	<20090207181628.13667.73400.stgit@mchn012c.ww002.siemens.net>
In-Reply-To: <20090207181628.13667.73400.stgit@mchn012c.ww002.siemens.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Jan Kiszka wrote:
> If the backing file is encrypted, 'info block' currently does not report
> the disk as encrypted. Fix this by used the standard API to check disk
> encryption mode.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>
>  block.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/block.c b/block.c
> index 78982f4..82c2016 100644
> --- a/block.c
> +++ b/block.c
> @@ -1056,7 +1056,7 @@ void bdrv_info(void)
>  	    }
>              term_printf(" ro=%d", bs->read_only);
>              term_printf(" drv=%s", bs->drv->format_name);
> -            if (bs->encrypted)
> +            if (bdrv_is_encrypted(bs))
>                  term_printf(" encrypted");
>   

It's a bit more easily parsable if it's in the format encrypted=[1|0].

Regards,

Anthony Liguori

>          } else {
>              term_printf(" [not inserted]");
>
>
>
>
>