From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LWYA1-0000SF-Hm
	for qemu-devel@nongnu.org; Mon, 09 Feb 2009 10:35:01 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LWYA0-0000Rk-Sk
	for qemu-devel@nongnu.org; Mon, 09 Feb 2009 10:35:01 -0500
Received: from [199.232.76.173] (port=36411 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LWYA0-0000Rd-IC
	for qemu-devel@nongnu.org; Mon, 09 Feb 2009 10:35:00 -0500
Received: from lizzard.sbs.de ([194.138.37.39]:21866)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <jan.kiszka@siemens.com>) id 1LWYA0-0003Tr-0K
	for qemu-devel@nongnu.org; Mon, 09 Feb 2009 10:35:00 -0500
Received: from mail2.sbs.de (localhost [127.0.0.1])
	by lizzard.sbs.de (8.12.11.20060308/8.12.11) with ESMTP id
	n19FYvWC026392
	for <qemu-devel@nongnu.org>; Mon, 9 Feb 2009 16:34:57 +0100
Received: from [139.25.109.167] (mchn012c.mchp.siemens.de [139.25.109.167]
	(may be forged))
	by mail2.sbs.de (8.12.11.20060308/8.12.11) with ESMTP id n19FYut4023044
	for <qemu-devel@nongnu.org>; Mon, 9 Feb 2009 16:34:57 +0100
Message-ID: <49904D20.40007@siemens.com>
Date: Mon, 09 Feb 2009 16:34:56 +0100
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <20090207181627.13667.9979.stgit@mchn012c.ww002.siemens.net>	<20090207181627.13667.72268.stgit@mchn012c.ww002.siemens.net>
	<4990419B.7060908@us.ibm.com>
In-Reply-To: <4990419B.7060908@us.ibm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 02/17] block: Improve bdrv_iterate
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Anthony Liguori wrote:
> Jan Kiszka wrote:
>> Make bdrv_iterate more useful by passing the BlockDriverState to the
>> iterator instead of the device name.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>>   
> 
>> ---
>>
>>  block.c   |    4 ++--
>>  block.h   |    3 ++-
>>  monitor.c |    3 ++-
>>   
> 
> $ grep -l bdrv_iterate *.c hw/*.c
> block.c
> monitor.c
> qemu-img.c
> vl.c
> 
> So this patch will break the build.

$ grep -l "bdrv_iterate(" *.c hw/*.c
block.c
monitor.c

Unless I'm totally blind, all users have been converted (there's only
one). And it still builds for all targets and tools.

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux