From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LWYAh-0000fp-2k for qemu-devel@nongnu.org; Mon, 09 Feb 2009 10:35:43 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LWYAf-0000fL-Fa for qemu-devel@nongnu.org; Mon, 09 Feb 2009 10:35:42 -0500 Received: from [199.232.76.173] (port=36426 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LWYAf-0000fG-9J for qemu-devel@nongnu.org; Mon, 09 Feb 2009 10:35:41 -0500 Received: from lizzard.sbs.de ([194.138.37.39]:22086) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LWYAe-0003Yv-OD for qemu-devel@nongnu.org; Mon, 09 Feb 2009 10:35:41 -0500 Received: from mail2.sbs.de (localhost [127.0.0.1]) by lizzard.sbs.de (8.12.11.20060308/8.12.11) with ESMTP id n19FZcnN027425 for ; Mon, 9 Feb 2009 16:35:38 +0100 Received: from [139.25.109.167] (mchn012c.mchp.siemens.de [139.25.109.167] (may be forged)) by mail2.sbs.de (8.12.11.20060308/8.12.11) with ESMTP id n19FZcMI024056 for ; Mon, 9 Feb 2009 16:35:38 +0100 Message-ID: <49904D4A.2030907@siemens.com> Date: Mon, 09 Feb 2009 16:35:38 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <20090207181627.13667.9979.stgit@mchn012c.ww002.siemens.net> <20090207181628.13667.73400.stgit@mchn012c.ww002.siemens.net> <499041E7.4070005@us.ibm.com> In-Reply-To: <499041E7.4070005@us.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 04/17] monitor: Report encrypted disks in snapshot mode Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Anthony Liguori wrote: > Jan Kiszka wrote: >> If the backing file is encrypted, 'info block' currently does not report >> the disk as encrypted. Fix this by used the standard API to check disk >> encryption mode. >> >> Signed-off-by: Jan Kiszka >> --- >> >> block.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/block.c b/block.c >> index 78982f4..82c2016 100644 >> --- a/block.c >> +++ b/block.c >> @@ -1056,7 +1056,7 @@ void bdrv_info(void) >> } >> term_printf(" ro=%d", bs->read_only); >> term_printf(" drv=%s", bs->drv->format_name); >> - if (bs->encrypted) >> + if (bdrv_is_encrypted(bs)) >> term_printf(" encrypted"); >> > > It's a bit more easily parsable if it's in the format encrypted=[1|0]. > OK, will change this. Jan -- Siemens AG, Corporate Technology, CT SE 2 Corporate Competence Center Embedded Linux