From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LWZHa-0003Ek-R0
	for qemu-devel@nongnu.org; Mon, 09 Feb 2009 11:46:54 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LWZHX-0003Ct-9P
	for qemu-devel@nongnu.org; Mon, 09 Feb 2009 11:46:54 -0500
Received: from [199.232.76.173] (port=49147 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LWZHX-0003Cl-3E
	for qemu-devel@nongnu.org; Mon, 09 Feb 2009 11:46:51 -0500
Received: from an-out-0708.google.com ([209.85.132.240]:56003)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1LWZHW-00038K-NY
	for qemu-devel@nongnu.org; Mon, 09 Feb 2009 11:46:50 -0500
Received: by an-out-0708.google.com with SMTP id b6so1009978ana.37
	for <qemu-devel@nongnu.org>; Mon, 09 Feb 2009 08:46:50 -0800 (PST)
Message-ID: <49905DE1.7070808@codemonkey.ws>
Date: Mon, 09 Feb 2009 10:46:25 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [6567] KVM: Get all cpuid values from function 2
	(Amit	Shah)
References: <E1LWYP7-000785-3Z@cvs.savannah.gnu.org>
	<4990548C.60706@redhat.com>
In-Reply-To: <4990548C.60706@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Avi Kivity wrote:
> Anthony Liguori wrote:
>> Revision: 6567
>>           http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6567
>> Author:   aliguori
>> Date:     2009-02-09 15:50:36 +0000 (Mon, 09 Feb 2009)
>>
>> Log Message:
>> -----------
>> KVM: Get all cpuid values from function 2 (Amit Shah)
>>
>> cpuid function 2 can have multiple values to describe cache behaviour.
>> Loop till we have fetched all the values.
>>   
>
> Note that if we are rescheduled on another cpu, or if another process 
> calls cpuid 2 during the loop on the same cpu, this will break.

That's unfortunate.  If cpuid values can differ for individual 
processors, than I don't see a great way to avoid this problem in general.

Regards,

Anthony Liguori