From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LXH2n-0007ww-Kq for qemu-devel@nongnu.org; Wed, 11 Feb 2009 10:30:33 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LXH2l-0007ve-Ni for qemu-devel@nongnu.org; Wed, 11 Feb 2009 10:30:32 -0500 Received: from [199.232.76.173] (port=51917 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LXH2l-0007vU-H7 for qemu-devel@nongnu.org; Wed, 11 Feb 2009 10:30:31 -0500 Received: from mx2.redhat.com ([66.187.237.31]:47165) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LXH2l-0003DV-3b for qemu-devel@nongnu.org; Wed, 11 Feb 2009 10:30:31 -0500 Message-ID: <4992EF12.3000103@redhat.com> Date: Wed, 11 Feb 2009 17:30:26 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH] remove smaller slots if registering a bigger one References: <1234360034-19459-1-git-send-email-glommer@redhat.com> <4992DF4B.6070109@siemens.com> <20090211143732.GA27729@poweredge.glommer> <4992E499.8050502@siemens.com> In-Reply-To: <4992E499.8050502@siemens.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Glauber Costa , aliguori@us.ibm.com Jan Kiszka wrote: >> Which is fine. I'd prefer it to be here, so we can analyse it case by case. >> The old memory code for kvm was totally messy, in part because we tried to >> hug the world at once, with some code paths that were almost never hit. >> >> Slot management can easily get very complicated. and trying to come up >> with a solution that accounts for all problems at once may backfire on us. >> >> > > Well, then "fix" all users... > Making memory management in qemu symmetric (any cpu_register_physical_memory() must be followed by a cpu_unregister_physical_memory() with the same parameters) is a good idea. -- error compiling committee.c: too many arguments to function