From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LXLCm-0007IR-RJ for qemu-devel@nongnu.org; Wed, 11 Feb 2009 14:57:08 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LXLCk-0007Gn-3Z for qemu-devel@nongnu.org; Wed, 11 Feb 2009 14:57:08 -0500 Received: from [199.232.76.173] (port=46228 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LXLCj-0007Gd-TR for qemu-devel@nongnu.org; Wed, 11 Feb 2009 14:57:05 -0500 Received: from mail-qy0-f20.google.com ([209.85.221.20]:45998) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LXLCj-0005Wd-Dh for qemu-devel@nongnu.org; Wed, 11 Feb 2009 14:57:05 -0500 Received: by qyk13 with SMTP id 13so838104qyk.10 for ; Wed, 11 Feb 2009 11:57:04 -0800 (PST) Message-ID: <49932D75.3090406@codemonkey.ws> Date: Wed, 11 Feb 2009 13:56:37 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [RFC] Machine description as data References: <87iqnh6kyv.fsf@pike.pond.sub.org> <49932089.2050708@codemonkey.ws> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Blue Swirl wrote: > On 2/11/09, Anthony Liguori wrote: > >> I think your approach is pretty sound. A few observations: >> >> 1) obviously need to eliminate the code duplication >> >> 2) the new code should fit with the rest of QEMU stylistically >> >> 3) I'd prefer incremental vs. perfect so let's try to do as much >> refactoring that will be required before actually going the full 9 yards and >> implementing the config file. >> >> 4) we don't have to solve all problems all at once as long as we don't >> regress existing features >> > > I'd still want to see if a FDT based solution is possible before > taking a homebrew version. > I think I mentioned earlier that I am heavily bias toward a FDT solution. What I'm suggesting though is that we can do some of the required cleanup (like device refactoring) before introducing any of the tree stuff. Regards, Anthony Liguori