qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] KVM: cpuid function 2: store all values
@ 2009-02-11 14:29 Amit Shah
  2009-02-11 21:01 ` [Qemu-devel] " Anthony Liguori
  0 siblings, 1 reply; 2+ messages in thread
From: Amit Shah @ 2009-02-11 14:29 UTC (permalink / raw)
  To: aliguori; +Cc: Amit Shah, qemu-devel

Incrementing the array index was missed in the previous series which causes
us to not store all the values.

Signed-off-by: Amit Shah <amit.shah@redhat.com>
---
 qemu/target-i386/kvm.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/qemu/target-i386/kvm.c b/qemu/target-i386/kvm.c
index 19b08d8..86745b1 100644
--- a/qemu/target-i386/kvm.c
+++ b/qemu/target-i386/kvm.c
@@ -74,6 +74,7 @@ int kvm_arch_init_vcpu(CPUState *env)
                 c->ebx = ebx;
                 c->ecx = ecx;
                 c->edx = edx;
+                c = &cpuid_data.entries[++cpuid_i];
             }
             break;
         }
-- 
1.6.0.6

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Qemu-devel] Re: [PATCH] KVM: cpuid function 2: store all values
  2009-02-11 14:29 [Qemu-devel] [PATCH] KVM: cpuid function 2: store all values Amit Shah
@ 2009-02-11 21:01 ` Anthony Liguori
  0 siblings, 0 replies; 2+ messages in thread
From: Anthony Liguori @ 2009-02-11 21:01 UTC (permalink / raw)
  To: Amit Shah; +Cc: qemu-devel

Amit Shah wrote:
> Incrementing the array index was missed in the previous series which causes
> us to not store all the values.
>
> Signed-off-by: Amit Shah <amit.shah@redhat.com>
> ---
>  qemu/target-i386/kvm.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/qemu/target-i386/kvm.c b/qemu/target-i386/kvm.c
>   

Applied.  Thanks.

I had to manually fix up the patch to apply with -p1.  Please resubmit 
your other one against SVN though.

Regards,

Anthony Liguori

> index 19b08d8..86745b1 100644
> --- a/qemu/target-i386/kvm.c
> +++ b/qemu/target-i386/kvm.c
> @@ -74,6 +74,7 @@ int kvm_arch_init_vcpu(CPUState *env)
>                  c->ebx = ebx;
>                  c->ecx = ecx;
>                  c->edx = edx;
> +                c = &cpuid_data.entries[++cpuid_i];
>              }
>              break;
>          }
>   

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-02-11 21:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-11 14:29 [Qemu-devel] [PATCH] KVM: cpuid function 2: store all values Amit Shah
2009-02-11 21:01 ` [Qemu-devel] " Anthony Liguori

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).