From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LY2pE-0005en-5e
	for qemu-devel@nongnu.org; Fri, 13 Feb 2009 13:31:44 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LY2pC-0005dC-Oz
	for qemu-devel@nongnu.org; Fri, 13 Feb 2009 13:31:43 -0500
Received: from [199.232.76.173] (port=34909 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LY2pC-0005d2-Er
	for qemu-devel@nongnu.org; Fri, 13 Feb 2009 13:31:42 -0500
Received: from e31.co.us.ibm.com ([32.97.110.149]:50809)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <aliguori@us.ibm.com>) id 1LY2pC-0002VC-20
	for qemu-devel@nongnu.org; Fri, 13 Feb 2009 13:31:42 -0500
Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com
	[9.17.195.227])
	by e31.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id n1DITJpI007828
	for <qemu-devel@nongnu.org>; Fri, 13 Feb 2009 11:29:19 -0700
Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168])
	by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id
	n1DIVXvW184156
	for <qemu-devel@nongnu.org>; Fri, 13 Feb 2009 11:31:36 -0700
Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1])
	by d03av02.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
	n1DIVXbM006641
	for <qemu-devel@nongnu.org>; Fri, 13 Feb 2009 11:31:33 -0700
Message-ID: <4995BC63.8040501@us.ibm.com>
Date: Fri, 13 Feb 2009 12:30:59 -0600
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] PATCH: 1/7: Extend 'info vnc' output to show client
References: <20090212145302.GO9894@redhat.com>
	<20090212150134.GQ9894@redhat.com>
In-Reply-To: <20090212150134.GQ9894@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org

Daniel P. Berrange wrote:
> The current 'info vnc' monitor output just displays the VNC server address
> as provided by the -vnc command line flag. This isn't particularly useful
> since it doesn't tell you what VNC is actually listening on. eg, if you
> use '-vnc :1' it is useful to know whether this translated to '0.0.0.0:5901'
> or chose IPv6 ':::5901'.  It is also useful to know the address of the
> client that is currently connected. It is also useful to know the active
> authentication (if any).
>
> @@ -2518,3 +2626,11 @@ int vnc_display_open(DisplayState *ds, c
>  
>      return qemu_set_fd_handler2(vs->lsock, vnc_listen_poll, vnc_listen_read, NULL, vs);
>  }
> +
> +/*
> + * Local variables:
> + *  c-indent-level: 4
> + *  c-basic-offset: 4
> + *  tab-width: 8
> + * End:
> + */
>   

I'd prefer you not add this randomly in a patch.

Regards,

Anthony Liguori