From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LYRim-00054y-Ez for qemu-devel@nongnu.org; Sat, 14 Feb 2009 16:06:44 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LYRij-00052L-Eg for qemu-devel@nongnu.org; Sat, 14 Feb 2009 16:06:42 -0500 Received: from [199.232.76.173] (port=60668 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LYRij-00052F-Am for qemu-devel@nongnu.org; Sat, 14 Feb 2009 16:06:41 -0500 Received: from yx-out-1718.google.com ([74.125.44.152]:6013) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LYRii-0000yO-KN for qemu-devel@nongnu.org; Sat, 14 Feb 2009 16:06:40 -0500 Received: by yx-out-1718.google.com with SMTP id 4so1138941yxp.82 for ; Sat, 14 Feb 2009 13:06:37 -0800 (PST) Message-ID: <49973240.2070106@codemonkey.ws> Date: Sat, 14 Feb 2009 15:06:08 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Fix incorrect attempt to clear a flag in vnc.c References: <4996BD8A.2050807@moose.net> In-Reply-To: <4996BD8A.2050807@moose.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Brian Kress wrote: > In vnc.c in pixel_format_message, the code tries to clear the > QEMU_ALLOCATED_FLAG > from the client display surface, however it uses the wrong operator > and ends up enabling all > other flags. Most notably this enables the big endian flag and causes > some chaos. Can you add a Signed-off-by line? Regards, Anthony Liguori